SkCpu w/o static initializer

SkCpu w/o static initializer

I think I cracked it.

Though, this may not technically be legal C++...
I've only got one definition of SkCpu::gCachedFeatures,
but two different declarations: non-const in SkCpu.cpp, const elsewhere.

Is this... 
   - legal C++? 
   - not C++ but probably works as I think?
   - not C++ and will probably blow up?
   - who knows, let's see?

I have tested that the features are cached properly, read properly, and that the generated code treats SkCpu::gCachedFeatures as a global constant outside SkCpu.cpp.  So it all observably works optimally.

Expanding testing to more bots.
TBR=reed@google.com

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1905683003

Committed: https://skia.googlesource.com/skia/+/eb85fd746d6390f53e250583a0544bf59ed34b35

[mtklein_C, 2016-04-20 22:16:33]

Description was changed from

==========
compromise

BUG=skia:
==========

to

==========
compromise

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[mtklein, 2016-04-21 14:49:15]

Description was changed from

==========
compromise

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
SkCpu w/o static initializer

I think I cracked it.  Though, this may not technically be legal C++...

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[mtklein, 2016-04-21 14:55:31]

Description was changed from

==========
SkCpu w/o static initializer

I think I cracked it.  Though, this may not technically be legal C++...

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
SkCpu w/o static initializer

I think I cracked it.

Though, this may not technically be legal C++...
I've only got one definition of SkCpu::gCachedFeatures,
but two different declarations: non-const in SkCpu.cpp, const elsewhere.

Is this... 
   - legal C++? 
   - not C++ but probably works as I think?
   - not C++ and will probably blow up?
   - who knows, let's see?

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[mtklein, 2016-04-21 14:56:59]

Description was changed from

==========
SkCpu w/o static initializer

I think I cracked it.

Though, this may not technically be legal C++...
I've only got one definition of SkCpu::gCachedFeatures,
but two different declarations: non-const in SkCpu.cpp, const elsewhere.

Is this... 
   - legal C++? 
   - not C++ but probably works as I think?
   - not C++ and will probably blow up?
   - who knows, let's see?

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
SkCpu w/o static initializer

I think I cracked it.

Though, this may not technically be legal C++...
I've only got one definition of SkCpu::gCachedFeatures,
but two different declarations: non-const in SkCpu.cpp, const elsewhere.

Is this... 
   - legal C++? 
   - not C++ but probably works as I think?
   - not C++ and will probably blow up?
   - who knows, let's see?

I have tested that the features are cached properly, read properly, and that the
generated code treats SkCpu::gCachedFeatures as a global constant outside
SkCpu.cpp.  So it all observably works optimally.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[mtklein_C, 2016-04-21 14:57:16]

mtklein@chromium.org changed reviewers:
+ bungeman@google.com

[mtklein_C, 2016-04-21 14:57:26]

The CQ bit was checked by mtklein@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-21 14:57:36]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1905683003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1905683003/40001

[commit-bot: I haz the power, 2016-04-21 15:00:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-21 15:00:26]

Dry run: Try jobs failed on following builders:
  Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)

[mtklein, 2016-04-21 15:06:03]

On 2016/04/21 at 15:00:26, commit-bot wrote:
> Dry run: Try jobs failed on following builders:
>   Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)

Hmm... I guess that link error in my answer... must be implementation (linker)
defined?

[mtklein_C, 2016-04-21 15:13:13]

The CQ bit was checked by mtklein@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-21 15:13:24]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1905683003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1905683003/60001

[mtklein_C, 2016-04-21 15:24:53]

Ok, sorry for the false start earlier.  This version should be good to go.

It continues to use a static initializer on Windows, but uses the new hack
to present `uint32_t gCachedFeatures` to SkCpu.cpp and `const uint32_t
gCachedFeatures` to other compilation units when not targeting Windows.

[commit-bot: I haz the power, 2016-04-21 15:27:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-21 15:27:36]

Dry run: This issue passed the CQ dry run.

[mtklein, 2016-04-21 17:33:34]

Description was changed from

==========
SkCpu w/o static initializer

I think I cracked it.

Though, this may not technically be legal C++...
I've only got one definition of SkCpu::gCachedFeatures,
but two different declarations: non-const in SkCpu.cpp, const elsewhere.

Is this... 
   - legal C++? 
   - not C++ but probably works as I think?
   - not C++ and will probably blow up?
   - who knows, let's see?

I have tested that the features are cached properly, read properly, and that the
generated code treats SkCpu::gCachedFeatures as a global constant outside
SkCpu.cpp.  So it all observably works optimally.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
SkCpu w/o static initializer

I think I cracked it.

Though, this may not technically be legal C++...
I've only got one definition of SkCpu::gCachedFeatures,
but two different declarations: non-const in SkCpu.cpp, const elsewhere.

Is this... 
   - legal C++? 
   - not C++ but probably works as I think?
   - not C++ and will probably blow up?
   - who knows, let's see?

I have tested that the features are cached properly, read properly, and that the
generated code treats SkCpu::gCachedFeatures as a global constant outside
SkCpu.cpp.  So it all observably works optimally.

Expanding testing to more bots.
TBR=reed@google.com

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[mtklein, 2016-04-21 17:33:36]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2016-04-21 17:33:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1905683003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1905683003/60001

[commit-bot: I haz the power, 2016-04-21 17:34:45]

Description was changed from

==========
SkCpu w/o static initializer

I think I cracked it.

Though, this may not technically be legal C++...
I've only got one definition of SkCpu::gCachedFeatures,
but two different declarations: non-const in SkCpu.cpp, const elsewhere.

Is this... 
   - legal C++? 
   - not C++ but probably works as I think?
   - not C++ and will probably blow up?
   - who knows, let's see?

I have tested that the features are cached properly, read properly, and that the
generated code treats SkCpu::gCachedFeatures as a global constant outside
SkCpu.cpp.  So it all observably works optimally.

Expanding testing to more bots.
TBR=reed@google.com

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
SkCpu w/o static initializer

I think I cracked it.

Though, this may not technically be legal C++...
I've only got one definition of SkCpu::gCachedFeatures,
but two different declarations: non-const in SkCpu.cpp, const elsewhere.

Is this... 
   - legal C++? 
   - not C++ but probably works as I think?
   - not C++ and will probably blow up?
   - who knows, let's see?

I have tested that the features are cached properly, read properly, and that the
generated code treats SkCpu::gCachedFeatures as a global constant outside
SkCpu.cpp.  So it all observably works optimally.

Expanding testing to more bots.
TBR=reed@google.com

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/eb85fd746d6390f53e250583a0544bf59ed34b35
==========

[commit-bot: I haz the power, 2016-04-21 17:34:45]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/eb85fd746d6390f53e250583a0544bf59ed34b35