extensions/renderer/api/display_source/wifi_display/wifi_display_video_encoder.cc - Issue 1905683002: [chrome.displaySource] Implement hardware accelerated H.264 video encoder.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/api/display_source/wifi_display/wifi_display_video_encoder.cc

Issue 1905683002: [chrome.displaySource] Implement hardware accelerated H.264 video encoder. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Error logging, scoped_refptr, unique_ptr Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« extensions/renderer/api/display_source/wifi_display/wifi_display_video_encoder.h ('K') | « extensions/renderer/api/display_source/wifi_display/wifi_display_video_encoder.h ('k') | extensions/renderer/api/display_source/wifi_display/wifi_display_video_encoder_vea.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/renderer/api/display_source/wifi_display/wifi_display_video_encoder.cc

diff --git a/extensions/renderer/api/display_source/wifi_display/wifi_display_video_encoder.cc b/extensions/renderer/api/display_source/wifi_display/wifi_display_video_encoder.cc

index 5a21291787b836c45bf8806c3723f4c63feb778b..9d852eb9d5d8711328f5c2047c47682fd7680e68 100644

--- a/extensions/renderer/api/display_source/wifi_display/wifi_display_video_encoder.cc

+++ b/extensions/renderer/api/display_source/wifi_display/wifi_display_video_encoder.cc

@@ -25,8 +25,7 @@ WiFiDisplayVideoEncoder::~WiFiDisplayVideoEncoder() = default;

void WiFiDisplayVideoEncoder::Create(

const InitParameters& params,

const VideoEncoderCallback& encoder_callback) {

- NOTIMPLEMENTED();

- encoder_callback.Run(nullptr);

+ CreateVEA(params, encoder_callback);

}

void WiFiDisplayVideoEncoder::InsertRawVideoFrame(