[chrome.displaySource] Implement hardware accelerated H.264 video encoder.

[chrome.displaySource] Implement hardware accelerated H.264 video encoder.

This adds a hardware accelerated implementation of Wi-Fi Display H.264
video encoder. It uses media::VideoEncodeAccelerator for acceleration.
This patch is based on initial patch from Mikhail Pozdnyakov
<mikhail.pozdnyakov@intel.com>;.

This part of a Wi-Fi Display video encoder patch series:
 * https://codereview.chromium.org/1905673002/
   Add common functionality to base video encoder.
 * https://codereview.chromium.org/1905683002/  <-- This CL
   Implement hardware accelerated H.264 video encoder.
 * https://codereview.chromium.org/1900233004/
   Implement software based H.264 video encoder.

BUG=242107
Committed: https://crrev.com/16f8fcb07d59ea8ba7a8eb0d4a89f149116c001a
Cr-Commit-Position: refs/heads/master@{#390021}

[e_hakkinen, 2016-04-20 18:41:50]

Description was changed from

==========
[chrome.displaySource] Implement hardware accelerated H.264 video encoder.

This adds a hardware accelerated implementation of Wi-Fi Display H.264
video encoder. It uses media::VideoEncodeAccelerator for acceleration.
This patch is based on initial patch from Mikhail Pozdnyakov
<mikhail.pozdnyakov@intel.com>.

BUG=242107
==========

to

==========
[chrome.displaySource] Implement hardware accelerated H.264 video encoder.

This adds a hardware accelerated implementation of Wi-Fi Display H.264
video encoder. It uses media::VideoEncodeAccelerator for acceleration.
This patch is based on initial patch from Mikhail Pozdnyakov
<mikhail.pozdnyakov@intel.com>.

This part of a Wi-Fi Display video encoder patch series:
 * https://codereview.chromium.org/1905673002/
   Enhance video encoder base class.
 * https://codereview.chromium.org/1905683002/  <-- This CL
   Implement hardware accelerated H.264 video encoder.
 * https://codereview.chromium.org/1900233004/
   Implement software based H.264 video encoder.

BUG=242107
==========

[e_hakkinen, 2016-04-22 10:04:24]

Description was changed from

==========
[chrome.displaySource] Implement hardware accelerated H.264 video encoder.

This adds a hardware accelerated implementation of Wi-Fi Display H.264
video encoder. It uses media::VideoEncodeAccelerator for acceleration.
This patch is based on initial patch from Mikhail Pozdnyakov
<mikhail.pozdnyakov@intel.com>.

This part of a Wi-Fi Display video encoder patch series:
 * https://codereview.chromium.org/1905673002/
   Enhance video encoder base class.
 * https://codereview.chromium.org/1905683002/  <-- This CL
   Implement hardware accelerated H.264 video encoder.
 * https://codereview.chromium.org/1900233004/
   Implement software based H.264 video encoder.

BUG=242107
==========

to

==========
[chrome.displaySource] Implement hardware accelerated H.264 video encoder.

This adds a hardware accelerated implementation of Wi-Fi Display H.264
video encoder. It uses media::VideoEncodeAccelerator for acceleration.
This patch is based on initial patch from Mikhail Pozdnyakov
<mikhail.pozdnyakov@intel.com>.

This part of a Wi-Fi Display video encoder patch series:
 * https://codereview.chromium.org/1905673002/
   Add common functionality to base video encoder.
 * https://codereview.chromium.org/1905683002/  <-- This CL
   Implement hardware accelerated H.264 video encoder.
 * https://codereview.chromium.org/1900233004/
   Implement software based H.264 video encoder.

BUG=242107
==========

[e_hakkinen, 2016-04-22 16:30:15]

eero.hakkinen@intel.com changed reviewers:
+ alexander.shalamov@intel.com, asargent@chromium.org,
mikhail.pozdnyakov@intel.com

[e_hakkinen, 2016-04-22 16:30:16]

PTAL.

[e_hakkinen, 2016-04-22 16:30:48]

Patchset #1 (id:1) has been deleted

[Mikhail, 2016-04-26 13:38:48]

https://codereview.chromium.org/1905683002/diff/20001/extensions/renderer/api...
File
extensions/renderer/api/display_source/wifi_display/wifi_display_video_encoder_vea.cc
(right):

https://codereview.chromium.org/1905683002/diff/20001/extensions/renderer/api...
extensions/renderer/api/display_source/wifi_display/wifi_display_video_encoder_vea.cc:33:
const scoped_refptr<base::SingleThreadTaskRunner>& media_task_runner,
think it can be just scoped_refptr<base::SingleThreadTaskRunner>

https://codereview.chromium.org/1905683002/diff/20001/extensions/renderer/api...
extensions/renderer/api/display_source/wifi_display/wifi_display_video_encoder_vea.cc:58:
InProgressFrameEncode(const scoped_refptr<media::VideoFrame>& video_frame,
ditto

https://codereview.chromium.org/1905683002/diff/20001/extensions/renderer/api...
extensions/renderer/api/display_source/wifi_display/wifi_display_video_encoder_vea.cc:69:
media::VideoEncodeAccelerator* vea_;
media::VideoEncodeAccelerator* vea_;  // Owned on media thread.

https://codereview.chromium.org/1905683002/diff/20001/extensions/renderer/api...
extensions/renderer/api/display_source/wifi_display/wifi_display_video_encoder_vea.cc:127:
LOG(ERROR) << "Failed to init VEA";
here and below pls, s/LOG(ERROR)/DVLOG(1)

https://codereview.chromium.org/1905683002/diff/20001/extensions/renderer/api...
extensions/renderer/api/display_source/wifi_display/wifi_display_video_encoder_vea.cc:185:
LOG(ERROR) << "Impl::BitstreamBufferReady(): invalid bitstream_buffer_id="
DVLOG(1) << "WiFiDisplayVideoEncoderVEA::BitstreamBufferReady()"

[Mikhail, 2016-04-26 13:44:09]

https://codereview.chromium.org/1905683002/diff/20001/extensions/renderer/api...
File
extensions/renderer/api/display_source/wifi_display/wifi_display_video_encoder_vea.cc
(right):

https://codereview.chromium.org/1905683002/diff/20001/extensions/renderer/api...
extensions/renderer/api/display_source/wifi_display/wifi_display_video_encoder_vea.cc:123:
media::H264PROFILE_MAIN, params.bit_rate, this);
pls. add a comment:// TODO : Select media profile based on video format
capabilities negotiations with sink device.

[e_hakkinen, 2016-04-26 14:28:54]

https://codereview.chromium.org/1905683002/diff/20001/extensions/renderer/api...
File
extensions/renderer/api/display_source/wifi_display/wifi_display_video_encoder_vea.cc
(right):

https://codereview.chromium.org/1905683002/diff/20001/extensions/renderer/api...
extensions/renderer/api/display_source/wifi_display/wifi_display_video_encoder_vea.cc:33:
const scoped_refptr<base::SingleThreadTaskRunner>& media_task_runner,
On 2016/04/26 13:38:47, Mikhail wrote:
> think it can be just scoped_refptr<base::SingleThreadTaskRunner>

Done.

https://codereview.chromium.org/1905683002/diff/20001/extensions/renderer/api...
extensions/renderer/api/display_source/wifi_display/wifi_display_video_encoder_vea.cc:58:
InProgressFrameEncode(const scoped_refptr<media::VideoFrame>& video_frame,
On 2016/04/26 13:38:47, Mikhail wrote:
> ditto

Done.

https://codereview.chromium.org/1905683002/diff/20001/extensions/renderer/api...
extensions/renderer/api/display_source/wifi_display/wifi_display_video_encoder_vea.cc:69:
media::VideoEncodeAccelerator* vea_;
On 2016/04/26 13:38:48, Mikhail wrote:
> media::VideoEncodeAccelerator* vea_;  // Owned on media thread.

Done.

https://codereview.chromium.org/1905683002/diff/20001/extensions/renderer/api...
extensions/renderer/api/display_source/wifi_display/wifi_display_video_encoder_vea.cc:123:
media::H264PROFILE_MAIN, params.bit_rate, this);
On 2016/04/26 13:44:08, Mikhail wrote:
> pls. add a comment:// TODO : Select media profile based on video format
> capabilities negotiations with sink device.

Done.

https://codereview.chromium.org/1905683002/diff/20001/extensions/renderer/api...
extensions/renderer/api/display_source/wifi_display/wifi_display_video_encoder_vea.cc:127:
LOG(ERROR) << "Failed to init VEA";
On 2016/04/26 13:38:48, Mikhail wrote:
> here and below pls, s/LOG(ERROR)/DVLOG(1)

Done.

https://codereview.chromium.org/1905683002/diff/20001/extensions/renderer/api...
extensions/renderer/api/display_source/wifi_display/wifi_display_video_encoder_vea.cc:185:
LOG(ERROR) << "Impl::BitstreamBufferReady(): invalid bitstream_buffer_id="
On 2016/04/26 13:38:48, Mikhail wrote:
> DVLOG(1) << "WiFiDisplayVideoEncoderVEA::BitstreamBufferReady()"

Done.

[Mikhail, 2016-04-26 14:37:32]

lgtm

[Mikhail, 2016-04-26 18:35:37]

Antony, could you pls have a look?

[asargent_no_longer_on_chrome, 2016-04-26 19:12:08]

lgtm

https://codereview.chromium.org/1905683002/diff/40001/extensions/renderer/api...
File
extensions/renderer/api/display_source/wifi_display/wifi_display_video_encoder.h
(right):

https://codereview.chromium.org/1905683002/diff/40001/extensions/renderer/api...
extensions/renderer/api/display_source/wifi_display/wifi_display_video_encoder.h:68:
static void CreateVEA(const InitParameters& params,
nit: it might be helpful to have a comment here (or maybe above in this file
before the first use of it in a name) defining what VEA stands for, since it's
not a commonly well-known acronym.

[e_hakkinen, 2016-04-27 07:39:05]

https://codereview.chromium.org/1905683002/diff/40001/extensions/renderer/api...
File
extensions/renderer/api/display_source/wifi_display/wifi_display_video_encoder.h
(right):

https://codereview.chromium.org/1905683002/diff/40001/extensions/renderer/api...
extensions/renderer/api/display_source/wifi_display/wifi_display_video_encoder.h:68:
static void CreateVEA(const InitParameters& params,
On 2016/04/26 19:12:08, Antony Sargent wrote:
> nit: it might be helpful to have a comment here (or maybe above in this file
> before the first use of it in a name) defining what VEA stands for, since it's
> not a commonly well-known acronym. 

Done.

[e_hakkinen, 2016-04-27 07:39:20]

The CQ bit was checked by eero.hakkinen@intel.com

[e_hakkinen, 2016-04-27 07:39:20]

The patchset sent to the CQ was uploaded after l-g-t-m from
asargent@chromium.org, mikhail.pozdnyakov@intel.com
Link to the patchset: https://codereview.chromium.org/1905683002/#ps60001
(title: "Comments")

[commit-bot: I haz the power, 2016-04-27 07:39:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1905683002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1905683002/60001

[commit-bot: I haz the power, 2016-04-27 08:21:27]

Description was changed from

==========
[chrome.displaySource] Implement hardware accelerated H.264 video encoder.

This adds a hardware accelerated implementation of Wi-Fi Display H.264
video encoder. It uses media::VideoEncodeAccelerator for acceleration.
This patch is based on initial patch from Mikhail Pozdnyakov
<mikhail.pozdnyakov@intel.com>.

This part of a Wi-Fi Display video encoder patch series:
 * https://codereview.chromium.org/1905673002/
   Add common functionality to base video encoder.
 * https://codereview.chromium.org/1905683002/  <-- This CL
   Implement hardware accelerated H.264 video encoder.
 * https://codereview.chromium.org/1900233004/
   Implement software based H.264 video encoder.

BUG=242107
==========

to

==========
[chrome.displaySource] Implement hardware accelerated H.264 video encoder.

This adds a hardware accelerated implementation of Wi-Fi Display H.264
video encoder. It uses media::VideoEncodeAccelerator for acceleration.
This patch is based on initial patch from Mikhail Pozdnyakov
<mikhail.pozdnyakov@intel.com>.

This part of a Wi-Fi Display video encoder patch series:
 * https://codereview.chromium.org/1905673002/
   Add common functionality to base video encoder.
 * https://codereview.chromium.org/1905683002/  <-- This CL
   Implement hardware accelerated H.264 video encoder.
 * https://codereview.chromium.org/1900233004/
   Implement software based H.264 video encoder.

BUG=242107
==========

[commit-bot: I haz the power, 2016-04-27 08:21:28]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-04-27 08:22:53]

Description was changed from

==========
[chrome.displaySource] Implement hardware accelerated H.264 video encoder.

This adds a hardware accelerated implementation of Wi-Fi Display H.264
video encoder. It uses media::VideoEncodeAccelerator for acceleration.
This patch is based on initial patch from Mikhail Pozdnyakov
<mikhail.pozdnyakov@intel.com>.

This part of a Wi-Fi Display video encoder patch series:
 * https://codereview.chromium.org/1905673002/
   Add common functionality to base video encoder.
 * https://codereview.chromium.org/1905683002/  <-- This CL
   Implement hardware accelerated H.264 video encoder.
 * https://codereview.chromium.org/1900233004/
   Implement software based H.264 video encoder.

BUG=242107
==========

to

==========
[chrome.displaySource] Implement hardware accelerated H.264 video encoder.

This adds a hardware accelerated implementation of Wi-Fi Display H.264
video encoder. It uses media::VideoEncodeAccelerator for acceleration.
This patch is based on initial patch from Mikhail Pozdnyakov
<mikhail.pozdnyakov@intel.com>.

This part of a Wi-Fi Display video encoder patch series:
 * https://codereview.chromium.org/1905673002/
   Add common functionality to base video encoder.
 * https://codereview.chromium.org/1905683002/  <-- This CL
   Implement hardware accelerated H.264 video encoder.
 * https://codereview.chromium.org/1900233004/
   Implement software based H.264 video encoder.

BUG=242107

Committed: https://crrev.com/16f8fcb07d59ea8ba7a8eb0d4a89f149116c001a
Cr-Commit-Position: refs/heads/master@{#390021}
==========

[commit-bot: I haz the power, 2016-04-27 08:22:54]

Patchset 3 (id:??) landed as
https://crrev.com/16f8fcb07d59ea8ba7a8eb0d4a89f149116c001a
Cr-Commit-Position: refs/heads/master@{#390021}