content/browser/media/webrtc_aecdump_browsertest.cc - Issue 190563002: Refactored how WebRTC content browser tests talk to their javascript.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/media/webrtc_aecdump_browsertest.cc

Issue 190563002: Refactored how WebRTC content browser tests talk to their javascript. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/media/webrtc_aecdump_browsertest.cc

diff --git a/content/browser/media/webrtc_aecdump_browsertest.cc b/content/browser/media/webrtc_aecdump_browsertest.cc

index 90e61fdda4350dddb9ba9a44edf86c3c81a844f8..2cbaa593dc310804ed8bd6001af2dfe8ea893046 100644

--- a/content/browser/media/webrtc_aecdump_browsertest.cc

+++ b/content/browser/media/webrtc_aecdump_browsertest.cc

@@ -71,8 +71,7 @@ IN_PROC_BROWSER_TEST_F(WebRtcAecDumpBrowserTest, MAYBE_CallWithAecDump) {

ASSERT_TRUE(ExecuteJavascript("forceIsac16KInSdp();"));

#endif

- EXPECT_TRUE(ExecuteJavascript("call({video: true, audio: true});"));

- ExpectTitle("OK");

+ ExecuteJavascriptAndWaitForOk("call({video: true, audio: true});");

EXPECT_TRUE(base::PathExists(dump_file_));

int64 file_size = 0;