Refactored how WebRTC content browser tests talk to their javascript.

Refactored how WebRTC content browser tests talk to their javascript.

We will now use the domAutomationController rather than looking at the
page title. This will confer the following advantages:

- Tests will fail right away when the js detects an error, rather than
  timing out.
- We will get a lot better stack traces when errors do occur.
- The communication path to the tests becomes more flexible with
  possibility for custom return values (for instance if we need to
  verify something in the C++ code or have a multi-stage test).

BUG=None
NOTRY=True

(doing notry since CQ gets stuck on telemetry test on mac_rel)

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255795

[phoglund_chromium, 2014-03-07 13:34:48]

tommi: owner stamp
perkj: main review

[phoglund_chromium, 2014-03-07 13:41:18]

https://codereview.chromium.org/190563002/diff/40001/content/test/data/media/...
File content/test/data/media/getusermedia.html (right):

https://codereview.chromium.org/190563002/diff/40001/content/test/data/media/...
content/test/data/media/getusermedia.html:164: // This function tries to
calculate the aspect ratio shown by the fake capture
Moved this guy: it seemed to belong here rather than in the general utilities.

https://codereview.chromium.org/190563002/diff/40001/content/test/data/media/...
File content/test/data/media/webrtc_test_utilities.js (right):

https://codereview.chromium.org/190563002/diff/40001/content/test/data/media/...
content/test/data/media/webrtc_test_utilities.js:41:
window.domAutomationController.send(error.stack);
This here gives a nice stack trace when the js detects a failure, which make the
tests quite a bit easier to debug.

https://codereview.chromium.org/190563002/diff/40001/content/test/data/media/...
content/test/data/media/webrtc_test_utilities.js:130: function
assertEquals(expected, actual) {
Renamed this to assertEquals since expectEquals generally means check condition
and then continue. Since this function actually interrupts execution with an
exception, assert is a better name.

[perkj_chrome, 2014-03-07 14:00:21]

Looks good.

https://codereview.chromium.org/190563002/diff/40001/content/browser/media/we...
File content/browser/media/webrtc_getusermedia_browsertest.cc (right):

https://codereview.chromium.org/190563002/diff/40001/content/browser/media/we...
content/browser/media/webrtc_getusermedia_browsertest.cc:123: // Let the stream
run for while in javascript.
for a w

https://codereview.chromium.org/190563002/diff/40001/content/test/data/media/...
File content/test/data/media/getusermedia.html (right):

https://codereview.chromium.org/190563002/diff/40001/content/test/data/media/...
content/test/data/media/getusermedia.html:248: 50);
indentation? maybe a comment saying what 50 means.

https://codereview.chromium.org/190563002/diff/40001/content/test/webrtc_cont...
File content/test/webrtc_content_browsertest_base.cc (right):

https://codereview.chromium.org/190563002/diff/40001/content/test/webrtc_cont...
content/test/webrtc_content_browsertest_base.cc:51:
ASSERT_TRUE(ExecuteJavascript("forceIsac16KInSdp();"));
Does this work for all tests regardless of the test design?

[phoglund_chromium, 2014-03-07 14:23:36]

PTAL

https://codereview.chromium.org/190563002/diff/40001/content/browser/media/we...
File content/browser/media/webrtc_getusermedia_browsertest.cc (right):

https://codereview.chromium.org/190563002/diff/40001/content/browser/media/we...
content/browser/media/webrtc_getusermedia_browsertest.cc:123: // Let the stream
run for while in javascript.
On 2014/03/07 14:00:21, perkj wrote:
> for a w

Done.

https://codereview.chromium.org/190563002/diff/40001/content/test/data/media/...
File content/test/data/media/getusermedia.html (right):

https://codereview.chromium.org/190563002/diff/40001/content/test/data/media/...
content/test/data/media/getusermedia.html:248: 50);
On 2014/03/07 14:00:21, perkj wrote:
> indentation? maybe a comment saying what 50 means.

Done.

https://codereview.chromium.org/190563002/diff/40001/content/test/webrtc_cont...
File content/test/webrtc_content_browsertest_base.cc (right):

https://codereview.chromium.org/190563002/diff/40001/content/test/webrtc_cont...
content/test/webrtc_content_browsertest_base.cc:51:
ASSERT_TRUE(ExecuteJavascript("forceIsac16KInSdp();"));
On 2014/03/07 14:00:21, perkj wrote:
> Does this work for all tests regardless of the test design?
You're right, this will break android for the getusermedia.html tests actually.
I'll move this back to the peerconnection.html tests only.

[tommi (sloooow) - chröme, 2014-03-07 14:48:16]

rs lgtm

[perkj_chrome, 2014-03-07 15:56:36]

lgtm

[phoglund_chromium, 2014-03-07 16:14:26]

The CQ bit was checked by phoglund@chromium.org

[commit-bot: I haz the power, 2014-03-07 16:15:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/phoglund@chromium.org/190563002/100001

[commit-bot: I haz the power, 2014-03-07 18:02:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-07 18:02:58]

Retried try job too often on android_dbg for step(s) slave_steps
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...

[phoglund_chromium, 2014-03-07 23:13:40]

The CQ bit was checked by phoglund@chromium.org

[commit-bot: I haz the power, 2014-03-07 23:15:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/phoglund@chromium.org/190563002/140001

[phoglund_chromium, 2014-03-08 08:31:41]

The CQ bit was checked by phoglund@chromium.org

[phoglund_chromium, 2014-03-08 09:28:32]

The CQ bit was unchecked by phoglund@chromium.org

[phoglund_chromium, 2014-03-08 09:28:38]

The CQ bit was checked by phoglund@chromium.org

[phoglund_chromium, 2014-03-08 09:44:10]

The CQ bit was unchecked by phoglund@chromium.org

[phoglund_chromium, 2014-03-08 15:55:08]

The CQ bit was checked by phoglund@chromium.org

[commit-bot: I haz the power, 2014-03-08 15:55:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/phoglund@chromium.org/190563002/160001

[commit-bot: I haz the power, 2014-03-08 16:37:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-08 16:37:20]

Retried try job too often on mac_rel for step(s) telemetry_perf_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[phoglund_chromium, 2014-03-08 17:56:57]

The CQ bit was checked by phoglund@chromium.org

[commit-bot: I haz the power, 2014-03-08 17:57:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/phoglund@chromium.org/190563002/160001

[commit-bot: I haz the power, 2014-03-08 19:04:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-08 19:04:27]

Retried try job too often on mac_rel for step(s) telemetry_perf_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[phoglund_chromium, 2014-03-08 20:51:14]

The CQ bit was checked by phoglund@chromium.org

[commit-bot: I haz the power, 2014-03-08 20:51:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/phoglund@chromium.org/190563002/160001

[commit-bot: I haz the power, 2014-03-08 21:01:01]

Change committed as 255795