Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Side by Side Diff: third_party/WebKit/Source/web/tests/WebViewTest.cpp

Issue 1905593002: Disable the crashing WebViewTest.ChooseValueFromDateTimeChooser test on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011, 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2011, 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 2049 matching lines...) Expand 10 before | Expand all | Expand 10 after
2060 WebKeyboardEvent keyEvent; 2060 WebKeyboardEvent keyEvent;
2061 keyEvent.windowsKeyCode = VKEY_SPACE; 2061 keyEvent.windowsKeyCode = VKEY_SPACE;
2062 keyEvent.type = WebInputEvent::RawKeyDown; 2062 keyEvent.type = WebInputEvent::RawKeyDown;
2063 keyEvent.setKeyIdentifierFromWindowsKeyCode(); 2063 keyEvent.setKeyIdentifierFromWindowsKeyCode();
2064 webView->handleInputEvent(keyEvent); 2064 webView->handleInputEvent(keyEvent);
2065 2065
2066 keyEvent.type = WebInputEvent::KeyUp; 2066 keyEvent.type = WebInputEvent::KeyUp;
2067 webView->handleInputEvent(keyEvent); 2067 webView->handleInputEvent(keyEvent);
2068 } 2068 }
2069 2069
2070 TEST_F(WebViewTest, ChooseValueFromDateTimeChooser) 2070 // TODO(crbug.com/605112) This test is crashing on Android (Nexus 4) bot.
2071 #if OS(ANDROID)
2072 #define MAYBE_ChooseValueFromDateTimeChooser DISABLED_ChooseValueFromDateTimeCho oser
2073 #else
2074 #define MAYBE_ChooseValueFromDateTimeChooser ChooseValueFromDateTimeChooser
2075 #endif
2076 TEST_F(WebViewTest, MAYBE_ChooseValueFromDateTimeChooser)
2071 { 2077 {
2072 DateTimeChooserWebViewClient client; 2078 DateTimeChooserWebViewClient client;
2073 std::string url = m_baseURL + "date_time_chooser.html"; 2079 std::string url = m_baseURL + "date_time_chooser.html";
2074 URLTestHelpers::registerMockedURLLoad(toKURL(url), "date_time_chooser.html") ; 2080 URLTestHelpers::registerMockedURLLoad(toKURL(url), "date_time_chooser.html") ;
2075 WebViewImpl* webViewImpl = m_webViewHelper.initializeAndLoad(url, true, 0, & client); 2081 WebViewImpl* webViewImpl = m_webViewHelper.initializeAndLoad(url, true, 0, & client);
2076 2082
2077 Document* document = webViewImpl->mainFrameImpl()->frame()->document(); 2083 Document* document = webViewImpl->mainFrameImpl()->frame()->document();
2078 2084
2079 HTMLInputElement* inputElement; 2085 HTMLInputElement* inputElement;
2080 2086
(...skipping 967 matching lines...) Expand 10 before | Expand all | Expand 10 after
3048 frame->setAutofillClient(&client); 3054 frame->setAutofillClient(&client);
3049 webView->setInitialFocus(false); 3055 webView->setInitialFocus(false);
3050 3056
3051 EXPECT_TRUE(webView->confirmComposition(WebString::fromUTF8(std::string("hel lo").c_str()))); 3057 EXPECT_TRUE(webView->confirmComposition(WebString::fromUTF8(std::string("hel lo").c_str())));
3052 EXPECT_EQ(1, client.textChangesFromUserGesture()); 3058 EXPECT_EQ(1, client.textChangesFromUserGesture());
3053 EXPECT_FALSE(UserGestureIndicator::processingUserGesture()); 3059 EXPECT_FALSE(UserGestureIndicator::processingUserGesture());
3054 frame->setAutofillClient(0); 3060 frame->setAutofillClient(0);
3055 } 3061 }
3056 3062
3057 } // namespace blink 3063 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698