Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1905553004:
Add UBSanVptr Linux buildbot (src part). (Closed)
DescriptionAdd 'UBSanVptr Linux' buildbot (src part).
Right now, we have a Clang ToT UBsan vptr buildbot:
https://build.chromium.org/p/chromium.fyi/builders/ClangToTLinuxUBSanVptr
Unfortunately, it's very slow, as it does not use goma
(Clang ToT could not do that). Not only we want to run ubsan vptr
tests more often, we also want to have a trybot (to be added later)
for the same configuration. At some point (closer to CFI launch on Linux),
the trybot will become mandatory for the commit queue, as we would like
to fail early.
BUG=588196
Committed: https://crrev.com/974fedf5c6b64da748d9ca4d0cae3fa8091592d1
Cr-Commit-Position: refs/heads/master@{#388651}
Patch Set 1 #Patch Set 2 : Add Linux to the bot name #Messages
Total messages: 22 (9 generated)
krasin@google.com changed reviewers: + dpranke@google.com
Description was changed from ========== Add UBSanVptr buildbot (src part). Right now, we have a Clang ToT UBsan vptr buildbot: https://build.chromium.org/p/chromium.fyi/builders/ClangToTLinuxUBSanVptr Unfortunately, it's very slow, as it does not use goma (Clang ToT could not do that). Not only we want to run ubsan vptr tests more often, we also want to have a trybot (to be added later) for the same configuration. At some point (closer to CFI launch on Linux), the trybot will become mandatory for the commit queue, as we would like to fail early. BUG=588196 ========== to ========== Add 'UBSanVptr Linux' buildbot (src part). Right now, we have a Clang ToT UBsan vptr buildbot: https://build.chromium.org/p/chromium.fyi/builders/ClangToTLinuxUBSanVptr Unfortunately, it's very slow, as it does not use goma (Clang ToT could not do that). Not only we want to run ubsan vptr tests more often, we also want to have a trybot (to be added later) for the same configuration. At some point (closer to CFI launch on Linux), the trybot will become mandatory for the commit queue, as we would like to fail early. BUG=588196 ==========
dpranke@chromium.org changed reviewers: + dpranke@chromium.org
lgtm
The CQ bit was checked by krasin@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1905553004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1905553004/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by krasin@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1905553004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1905553004/20001
Message was sent while issue was closed.
Description was changed from ========== Add 'UBSanVptr Linux' buildbot (src part). Right now, we have a Clang ToT UBsan vptr buildbot: https://build.chromium.org/p/chromium.fyi/builders/ClangToTLinuxUBSanVptr Unfortunately, it's very slow, as it does not use goma (Clang ToT could not do that). Not only we want to run ubsan vptr tests more often, we also want to have a trybot (to be added later) for the same configuration. At some point (closer to CFI launch on Linux), the trybot will become mandatory for the commit queue, as we would like to fail early. BUG=588196 ========== to ========== Add 'UBSanVptr Linux' buildbot (src part). Right now, we have a Clang ToT UBsan vptr buildbot: https://build.chromium.org/p/chromium.fyi/builders/ClangToTLinuxUBSanVptr Unfortunately, it's very slow, as it does not use goma (Clang ToT could not do that). Not only we want to run ubsan vptr tests more often, we also want to have a trybot (to be added later) for the same configuration. At some point (closer to CFI launch on Linux), the trybot will become mandatory for the commit queue, as we would like to fail early. BUG=588196 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
thakis@chromium.org changed reviewers: + thakis@chromium.org
Message was sent while issue was closed.
(try bots need to cycle in < 50 minutes. i'm not sure if cfi can do that if it needs to link and run tests in that time.)
Message was sent while issue was closed.
On 2016/04/21 01:40:01, Nico wrote: > (try bots need to cycle in < 50 minutes. i'm not sure if cfi can do that if it > needs to link and run tests in that time.) I think that's only true for things we keep in the CQ. Other try servers don't have that limit.
Message was sent while issue was closed.
On 2016/04/21 02:13:45, Dirk Pranke wrote: > On 2016/04/21 01:40:01, Nico wrote: > > (try bots need to cycle in < 50 minutes. i'm not sure if cfi can do that if it > > needs to link and run tests in that time.) > > I think that's only true for things we keep in the CQ. Other try servers don't > have that limit. Yes, but the CL description sounds like having it in the cq eventually is a goal.
Message was sent while issue was closed.
On 2016/04/21 02:15:00, Nico wrote: > On 2016/04/21 02:13:45, Dirk Pranke wrote: > > On 2016/04/21 01:40:01, Nico wrote: > > > (try bots need to cycle in < 50 minutes. i'm not sure if cfi can do that if > it > > > needs to link and run tests in that time.) > > > > I think that's only true for things we keep in the CQ. Other try servers don't > > have that limit. > > Yes, but the CL description sounds like having it in the cq eventually is a > goal. Ah, I missed that part. Yeah, that's gonna be a problem.
Message was sent while issue was closed.
On 2016/04/21 01:40:01, Nico wrote: > (try bots need to cycle in < 50 minutes. i'm not sure if cfi can do that if it > needs to link and run tests in that time.) Hi Nico, this is not a CFI bot, it's UBSan vptr, which does not require LTO => the build is fast as usual. UBSan (as you might remember) has higher runtime costs, but they are small enough to run tests as usual.
Message was sent while issue was closed.
The whole goal of this buildbot (and eventual try bot) is to simulate CFI vptr failures. While UBsan vptr and CFI vptr have slightly different failure modes, they are close enough to be useful.
Message was sent while issue was closed.
Description was changed from ========== Add 'UBSanVptr Linux' buildbot (src part). Right now, we have a Clang ToT UBsan vptr buildbot: https://build.chromium.org/p/chromium.fyi/builders/ClangToTLinuxUBSanVptr Unfortunately, it's very slow, as it does not use goma (Clang ToT could not do that). Not only we want to run ubsan vptr tests more often, we also want to have a trybot (to be added later) for the same configuration. At some point (closer to CFI launch on Linux), the trybot will become mandatory for the commit queue, as we would like to fail early. BUG=588196 ========== to ========== Add 'UBSanVptr Linux' buildbot (src part). Right now, we have a Clang ToT UBsan vptr buildbot: https://build.chromium.org/p/chromium.fyi/builders/ClangToTLinuxUBSanVptr Unfortunately, it's very slow, as it does not use goma (Clang ToT could not do that). Not only we want to run ubsan vptr tests more often, we also want to have a trybot (to be added later) for the same configuration. At some point (closer to CFI launch on Linux), the trybot will become mandatory for the commit queue, as we would like to fail early. BUG=588196 Committed: https://crrev.com/974fedf5c6b64da748d9ca4d0cae3fa8091592d1 Cr-Commit-Position: refs/heads/master@{#388651} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/974fedf5c6b64da748d9ca4d0cae3fa8091592d1 Cr-Commit-Position: refs/heads/master@{#388651} |
