Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(612)

Issue 1905553003: Adds DCHECK to BuiltinManifestProvider (Closed)

Created:
4 years, 8 months ago by sky
Modified:
4 years, 8 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adds DCHECK to BuiltinManifestProvider If someone adds a resource then it should be in the ResourceBundle. BUG=none TEST=none R=ben@chromium.org Committed: https://crrev.com/c0983cfb17df5d982784d7db711aa10d83d57ec0 Cr-Commit-Position: refs/heads/master@{#388606}

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M content/browser/mojo/mojo_shell_context.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
sky
4 years, 8 months ago (2016-04-20 21:28:22 UTC) #1
Ben Goodger (Google)
lgtm
4 years, 8 months ago (2016-04-20 22:30:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1905553003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1905553003/20001
4 years, 8 months ago (2016-04-20 22:41:01 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-21 00:00:41 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:27:50 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c0983cfb17df5d982784d7db711aa10d83d57ec0
Cr-Commit-Position: refs/heads/master@{#388606}

Powered by Google App Engine
This is Rietveld 408576698