Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(554)

Issue 1905533004: Revert duplication of "Record domains where Reader Mode is prompted or opened" (Closed)

Created:
4 years, 8 months ago by wychen
Modified:
4 years, 8 months ago
Reviewers:
jwd
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert duplication of "Record domains where Reader Mode is prompted or opened" This reverts commit 8dd3c54659c4e99b4ba31254fed0094defd4ffd1. The commit bot wrongly landed https://codereview.chromium.org/1873073002/ twice, but only partially for the second time. This is fixed here. BUG=602134 Committed: https://crrev.com/df24db2cac5d2a6d861beb266b5509cc9565edb7 Cr-Commit-Position: refs/heads/master@{#388849}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -15 lines) Patch
M tools/metrics/rappor/rappor.xml View 1 chunk +0 lines, -15 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
wychen
PTAL.
4 years, 8 months ago (2016-04-20 21:15:10 UTC) #2
jwd
lgtm
4 years, 8 months ago (2016-04-21 17:52:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1905533004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1905533004/1
4 years, 8 months ago (2016-04-21 18:44:58 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-21 19:33:07 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:37:37 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/df24db2cac5d2a6d861beb266b5509cc9565edb7
Cr-Commit-Position: refs/heads/master@{#388849}

Powered by Google App Engine
This is Rietveld 408576698