Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 190553004: Revert "Attempt to fix audio wedges by restarting all streams on OSX." (Closed)

Created:
6 years, 9 months ago by DaleCurtis
Modified:
6 years, 8 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, miu+watch_chromium.org
Visibility:
Public.

Description

Revert "Attempt to fix audio wedges by restarting all streams on OSX." This reverts commit http://crrev.com/238501 in favor a simpler approach which delays stream creation around suspend and resume events: http://crrev.com/247026 Care must be taken to monitor the UMA stat for increases after this lands. I'll also communicate with the YT team on the bug/ to ensure they provide some assistance in testing. BUG=160920 TEST=No stream hangs. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263076

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -175 lines) Patch
M media/audio/audio_manager.h View 1 chunk +0 lines, -5 lines 0 comments Download
M media/audio/audio_manager_base.h View 1 chunk +0 lines, -2 lines 0 comments Download
M media/audio/audio_manager_base.cc View 1 chunk +0 lines, -28 lines 0 comments Download
M media/audio/audio_output_controller.cc View 1 chunk +2 lines, -9 lines 0 comments Download
M media/audio/audio_output_dispatcher.h View 1 chunk +0 lines, -7 lines 0 comments Download
M media/audio/audio_output_dispatcher_impl.h View 1 chunk +0 lines, -3 lines 0 comments Download
M media/audio/audio_output_dispatcher_impl.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M media/audio/audio_output_proxy_unittest.cc View 1 chunk +0 lines, -71 lines 0 comments Download
M media/audio/audio_output_resampler.h View 1 chunk +0 lines, -2 lines 0 comments Download
M media/audio/audio_output_resampler.cc View 1 chunk +0 lines, -31 lines 0 comments Download
M media/audio/mock_audio_manager.h View 1 chunk +0 lines, -2 lines 0 comments Download
M media/audio/mock_audio_manager.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
DaleCurtis
Time to clean up this mess!
6 years, 9 months ago (2014-03-07 22:25:20 UTC) #1
DaleCurtis
Ping. Though I'm not going to land this until M36.
6 years, 9 months ago (2014-03-21 17:48:10 UTC) #2
scherkus (not reviewing)
sorry for delay -- the title of the CL made it look like it was ...
6 years, 9 months ago (2014-03-21 17:54:02 UTC) #3
DaleCurtis
Done. Thanks! Will land around 4/4.
6 years, 9 months ago (2014-03-21 18:03:16 UTC) #4
DaleCurtis
Bombs away!
6 years, 8 months ago (2014-04-10 18:24:41 UTC) #5
DaleCurtis
The CQ bit was checked by dalecurtis@chromium.org
6 years, 8 months ago (2014-04-10 18:24:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/190553004/1
6 years, 8 months ago (2014-04-10 18:24:53 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-10 19:16:22 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 8 months ago (2014-04-10 19:16:22 UTC) #9
DaleCurtis
The CQ bit was checked by dalecurtis@chromium.org
6 years, 8 months ago (2014-04-10 19:22:07 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/190553004/1
6 years, 8 months ago (2014-04-10 19:22:18 UTC) #11
commit-bot: I haz the power
6 years, 8 months ago (2014-04-10 21:01:10 UTC) #12
Message was sent while issue was closed.
Change committed as 263076

Powered by Google App Engine
This is Rietveld 408576698