Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 1905523002: Made --filter-string optional for emma_coverage. (Closed)

Created:
4 years, 8 months ago by BigBossZhiling
Modified:
4 years, 8 months ago
Reviewers:
jbudorick
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Made --filter-string optional for emma_coverage. If we set emma_coverage as true, and do not set --filter-string in args.gn, build will fail because --filter-string is mandatory. In this cl, I am making --filter-string optional for emma_coverage. BUG= Committed: https://crrev.com/6a18734145371ec315fb356119e63fb3c0661437 Cr-Commit-Position: refs/heads/master@{#388413}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M build/config/android/internal_rules.gni View 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
BigBossZhiling
4 years, 8 months ago (2016-04-20 01:24:13 UTC) #2
BigBossZhiling
Please take a look, John.
4 years, 8 months ago (2016-04-20 01:24:44 UTC) #3
jbudorick
lgtm
4 years, 8 months ago (2016-04-20 01:25:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1905523002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1905523002/1
4 years, 8 months ago (2016-04-20 01:33:05 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-20 02:56:31 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:20:22 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6a18734145371ec315fb356119e63fb3c0661437
Cr-Commit-Position: refs/heads/master@{#388413}

Powered by Google App Engine
This is Rietveld 408576698