Make ConfirmManagedSigninFragment public

Make ConfirmManagedSigninFragment public

This fixes the ValidFragment lint error in the class.

Committed: https://crrev.com/299f7a40b6905a1a0352ca0cfff3bc4cbec2ceac
Cr-Commit-Position: refs/heads/master@{#389912}

[Bernhard Bauer, 2016-04-21 12:31:20]

bauerb@chromium.org changed reviewers:
+ maxbogue@chromium.org

[Bernhard Bauer, 2016-04-21 12:31:21]

Please review. Thanks!

[maxbogue, 2016-04-21 16:46:34]

Hmm, this class was intentionally package private. Can you elaborate in the
description on why it must be public?

[Bernhard Bauer, 2016-04-22 15:36:42]

On 2016/04/21 16:46:34, maxbogue wrote:
> Hmm, this class was intentionally package private. Can you elaborate in the
> description on why it must be public?

Done.

[maxbogue, 2016-04-22 17:09:47]

On 2016/04/22 15:36:42, Bernhard Bauer wrote:
> On 2016/04/21 16:46:34, maxbogue wrote:
> > Hmm, this class was intentionally package private. Can you elaborate in the
> > description on why it must be public?
> 
> Done.

Oh, I meant the CL description. Why is package visibility a lint error?

[maxbogue, 2016-04-22 17:11:20]

https://codereview.chromium.org/1905513004/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/signin/ConfirmManagedSigninFragment.java
(right):

https://codereview.chromium.org/1905513004/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/signin/ConfirmManagedSigninFragment.java:19:
* This is an AlertDialog asking the user to confirm that he wants to sign in to
a managed account.
While you're here, could you change this to be gender-neutral wording? s/he
wants/they want/

If you s/AlertDialog/dialog/ it'll still fit on one line even.

https://codereview.chromium.org/1905513004/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/signin/ConfirmManagedSigninFragment.java:21:
// Public to avoid a Java lint error.
You can remove this; sorry for the miscommunication!

[Bernhard Bauer, 2016-04-26 09:19:05]

On 2016/04/22 17:09:47, maxbogue wrote:
> On 2016/04/22 15:36:42, Bernhard Bauer wrote:
> > On 2016/04/21 16:46:34, maxbogue wrote:
> > > Hmm, this class was intentionally package private. Can you elaborate in
the
> > > description on why it must be public?
> > 
> > Done.
> 
> Oh, I meant the CL description. Why is package visibility a lint error?

I've found
http://static.javadoc.io/com.android.tools.lint/lint-checks/24.2.2/com/androi...,
which states that fragment classes should be public, static, and have a public
empty constructor. I don't completely understand why the class needs to be
public, as it's instantiated via reflection anyway (and it does not appear to
crash at runtime), but Lint definitely does check for it.

https://codereview.chromium.org/1905513004/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/signin/ConfirmManagedSigninFragment.java
(right):

https://codereview.chromium.org/1905513004/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/signin/ConfirmManagedSigninFragment.java:19:
* This is an AlertDialog asking the user to confirm that he wants to sign in to
a managed account.
On 2016/04/22 17:11:20, maxbogue wrote:
> While you're here, could you change this to be gender-neutral wording? s/he
> wants/they want/
> 
> If you s/AlertDialog/dialog/ it'll still fit on one line even.

Done.

[maxbogue, 2016-04-26 16:49:33]

lgtm, thanks!

[Bernhard Bauer, 2016-04-26 22:01:06]

The CQ bit was checked by bauerb@chromium.org

[commit-bot: I haz the power, 2016-04-26 22:01:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1905513004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1905513004/40001

[commit-bot: I haz the power, 2016-04-26 22:07:28]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-26 22:09:26]

Description was changed from

==========
Make ConfirmManagedSigninFragment public

This fixes the ValidFragment lint error in the class.
==========

to

==========
Make ConfirmManagedSigninFragment public

This fixes the ValidFragment lint error in the class.

Committed: https://crrev.com/299f7a40b6905a1a0352ca0cfff3bc4cbec2ceac
Cr-Commit-Position: refs/heads/master@{#389912}
==========

[commit-bot: I haz the power, 2016-04-26 22:09:27]

Patchset 3 (id:??) landed as
https://crrev.com/299f7a40b6905a1a0352ca0cfff3bc4cbec2ceac
Cr-Commit-Position: refs/heads/master@{#389912}