third_party/WebKit/Source/devtools/front_end/extensions/ExtensionPanel.js - Issue 1905493002: Make the extension's sidebar pane auto-resizable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/extensions/ExtensionPanel.js

Issue 1905493002: Make the extension's sidebar pane auto-resizable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: clean up defineDeprecatedMethod, update defineDeprecatedProperty accordingly Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/extensions/ExtensionAPI.js ('K') | « third_party/WebKit/Source/devtools/front_end/extensions/ExtensionAPI.js ('k') | third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/extensions/ExtensionPanel.js

diff --git a/third_party/WebKit/Source/devtools/front_end/extensions/ExtensionPanel.js b/third_party/WebKit/Source/devtools/front_end/extensions/ExtensionPanel.js

index bb16a44d51cc963c4a9e4d564376eb0ef16f889c..d1da688cf6b4a571ac9986586381a7a2b0c063dc 100644

--- a/third_party/WebKit/Source/devtools/front_end/extensions/ExtensionPanel.js

+++ b/third_party/WebKit/Source/devtools/front_end/extensions/ExtensionPanel.js

@@ -192,6 +192,7 @@ WebInspector.ExtensionButton.prototype = {

WebInspector.ExtensionSidebarPane = function(server, panelName, title, id)

{

WebInspector.SidebarPane.call(this, title);

+ this.element.classList.add("fill");

this._panelName = panelName;

this._server = server;

this._id = id;

@@ -252,17 +253,6 @@ WebInspector.ExtensionSidebarPane.prototype = {

this._extensionView = new WebInspector.ExtensionView(this._server, this._id, url, "extension fill");

this._extensionView.show(this.element);

- if (!this.element.style.height)

- this.setHeight("150px");

- },

- /**

- * @param {string} height

- */

- setHeight: function(height)

- {

- this.element.style.height = height;

/**