Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: third_party/WebKit/LayoutTests/inspector/extensions/extensions-sidebar.html

Issue 1905493002: Make the extension's sidebar pane auto-resizable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix layout tests Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « AUTHORS ('k') | third_party/WebKit/LayoutTests/inspector/extensions/extensions-sidebar-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/inspector/extensions/extensions-sidebar.html
diff --git a/third_party/WebKit/LayoutTests/inspector/extensions/extensions-sidebar.html b/third_party/WebKit/LayoutTests/inspector/extensions/extensions-sidebar.html
index 8a62da8103aacebbc3718e244e55d67abb8095ae..7729922e8d812f09291e646ebfb307a6bc2c372b 100644
--- a/third_party/WebKit/LayoutTests/inspector/extensions/extensions-sidebar.html
+++ b/third_party/WebKit/LayoutTests/inspector/extensions/extensions-sidebar.html
@@ -44,7 +44,9 @@ function extension_sidebarSetPage(panelName, nextTest)
dumpObject(sidebar);
function onShown(win)
{
- output("sidebar height " + win.document.documentElement.getBoundingClientRect().height);
+ var sidebarHeight = win.document.documentElement.getBoundingClientRect().height;
+ if (win.innerHeight !== sidebarHeight)
+ output("sidebar height mismatch, expected: " + win.innerHeight + ", actual:" + sidebarHeight);
sidebar.onShown.removeListener(onShown);
nextTest();
}
« no previous file with comments | « AUTHORS ('k') | third_party/WebKit/LayoutTests/inspector/extensions/extensions-sidebar-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698