third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js - Issue 1905493002: Make the extension's sidebar pane auto-resizable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js

Issue 1905493002: Make the extension's sidebar pane auto-resizable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js

diff --git a/third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js b/third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js

index 9d8161edae6245d7cc2bfd932a580428936a5091..852bf4679bc88ccb37109ce19e0f679afc5e1150 100644

--- a/third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js

+++ b/third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js

@@ -340,7 +340,9 @@ WebInspector.ExtensionServer.prototype = {

var sidebar = this._clientObjects[message.id];

if (!sidebar)

return this._status.E_NOTFOUND(message.id);

- sidebar.setHeight(message.height);

+ console.warn("Setting height of the SidebarPane is deprecated.");

caseq 2016/04/20 01:20:50 Let's move that to front-end API instead, so the s

return this._status.OK();

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/extensions/ExtensionPanel.js ('k') | no next file » | no next file with comments »