Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js

Issue 1905493002: Make the extension's sidebar pane auto-resizable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/extensions/ExtensionPanel.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 322 matching lines...) Expand 10 before | Expand all | Expand 10 after
333 sidebarPanes: function() 333 sidebarPanes: function()
334 { 334 {
335 return this._sidebarPanes; 335 return this._sidebarPanes;
336 }, 336 },
337 337
338 _onSetSidebarHeight: function(message) 338 _onSetSidebarHeight: function(message)
339 { 339 {
340 var sidebar = this._clientObjects[message.id]; 340 var sidebar = this._clientObjects[message.id];
341 if (!sidebar) 341 if (!sidebar)
342 return this._status.E_NOTFOUND(message.id); 342 return this._status.E_NOTFOUND(message.id);
343 sidebar.setHeight(message.height); 343
344 console.warn("Setting height of the SidebarPane is deprecated.");
caseq 2016/04/20 01:20:50 Let's move that to front-end API instead, so the s
345
344 return this._status.OK(); 346 return this._status.OK();
345 }, 347 },
346 348
347 _onSetSidebarContent: function(message, port) 349 _onSetSidebarContent: function(message, port)
348 { 350 {
349 var sidebar = this._clientObjects[message.id]; 351 var sidebar = this._clientObjects[message.id];
350 if (!sidebar) 352 if (!sidebar)
351 return this._status.E_NOTFOUND(message.id); 353 return this._status.E_NOTFOUND(message.id);
352 354
353 /** 355 /**
(...skipping 727 matching lines...) Expand 10 before | Expand all | Expand 10 after
1081 /** 1083 /**
1082 * @typedef {{code: string, description: string, details: !Array.<*>}} 1084 * @typedef {{code: string, description: string, details: !Array.<*>}}
1083 */ 1085 */
1084 WebInspector.ExtensionStatus.Record; 1086 WebInspector.ExtensionStatus.Record;
1085 1087
1086 WebInspector.extensionAPI = {}; 1088 WebInspector.extensionAPI = {};
1087 defineCommonExtensionSymbols(WebInspector.extensionAPI); 1089 defineCommonExtensionSymbols(WebInspector.extensionAPI);
1088 1090
1089 /** @type {!WebInspector.ExtensionServer} */ 1091 /** @type {!WebInspector.ExtensionServer} */
1090 WebInspector.extensionServer; 1092 WebInspector.extensionServer;
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/extensions/ExtensionPanel.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698