tools/gn/location.h - Issue 1905473003: 🐣 GN: Print the import trail when parse errors occur.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/location.h

Issue 1905473003: 🐣 GN: Print the import trail when parse errors occur. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add null origin check Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/gn/location.h

diff --git a/tools/gn/location.h b/tools/gn/location.h

index 44d1a6fe68f614112bf1d57993cc8af8bb92755c..d1c875016dbf315e1eb42d2802dfe32bf6179d96 100644

--- a/tools/gn/location.h

+++ b/tools/gn/location.h

@@ -19,6 +19,7 @@ class Location {

int line_number() const { return line_number_; }

int column_number() const { return column_number_; }

int byte() const { return byte_; }

+ bool is_null() const;

brettw 2016/04/21 20:33:36 As per style guide, hacker_case function names sho

agrieve 2016/04/22 00:16:31 Done.

bool operator==(const Location& other) const;

bool operator!=(const Location& other) const;

@@ -45,6 +46,7 @@ class LocationRange {

const Location& begin() const { return begin_; }

const Location& end() const { return end_; }

+ bool is_null() const;

brettw 2016/04/21 20:33:36 Ditto.

agrieve 2016/04/22 00:16:31 Done.

LocationRange Union(const LocationRange& other) const;

« no previous file with comments | « tools/gn/loader.cc ('k') | tools/gn/location.cc » ('j') | no next file with comments »