Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1905473002:
media: Add liberato and watk as media/gpu android owners (Closed)
|
Created:
4 years, 8 months ago by xhwang Modified:
4 years, 8 months ago CC:
DaleCurtis, chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, liberato (no reviews please), piman+watch_chromium.org, posciak+watch_chromium.org, watk Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptionmedia: Add liberato and watk as media/gpu android owners
Committed: https://crrev.com/0ce639dc8be23e67c7eb33f00ed6d16d60865437
Cr-Commit-Position: refs/heads/master@{#388632}
Patch Set 1 #Patch Set 2 : android-only #
Total comments: 4
Patch Set 3 : comments addressed #Patch Set 4 : comments addressed #Messages
Total messages: 23 (8 generated)
xhwang@chromium.org changed reviewers: + sandersd@chromium.org
Please OWNERS review.
liberato / watk / dalecurtis: FYI
Description was changed from ========== media: Add liberato and watk as media/gpu owners ========== to ========== media: Add liberato and watk as media/gpu android owners ==========
PTAL again
https://codereview.chromium.org/1905473002/diff/20001/content/common/gpu/medi... File content/common/gpu/media/OWNERS (right): https://codereview.chromium.org/1905473002/diff/20001/content/common/gpu/medi... content/common/gpu/media/OWNERS:8: per-file *android*=watk@chromium.org Also avda* (which is probably a hint that those are named wrong, cf. crbug.com/605205) https://codereview.chromium.org/1905473002/diff/20001/media/gpu/OWNERS File media/gpu/OWNERS (right): https://codereview.chromium.org/1905473002/diff/20001/media/gpu/OWNERS#newcode8 media/gpu/OWNERS:8: per-file *android*=watk@chromium.org Full ownership makes sense for everything that's in there right now. What else is moving into media/gpu?
https://codereview.chromium.org/1905473002/diff/20001/content/common/gpu/medi... File content/common/gpu/media/OWNERS (right): https://codereview.chromium.org/1905473002/diff/20001/content/common/gpu/medi... content/common/gpu/media/OWNERS:8: per-file *android*=watk@chromium.org On 2016/04/20 18:54:05, sandersd wrote: > Also avda* (which is probably a hint that those are named wrong, cf. > crbug.com/605205) Done. It seems an Android folder makes a lot of sense. https://codereview.chromium.org/1905473002/diff/20001/media/gpu/OWNERS File media/gpu/OWNERS (right): https://codereview.chromium.org/1905473002/diff/20001/media/gpu/OWNERS#newcode8 media/gpu/OWNERS:8: per-file *android*=watk@chromium.org On 2016/04/20 18:54:05, sandersd wrote: > Full ownership makes sense for everything that's in there right now. What else > is moving into media/gpu? We'll move pretty much everything. See https://chromiumcodereview.appspot.com/1882373004/
comments addressed
dalecurtis@chromium.org changed reviewers: + dalecurtis@chromium.org
Should we switch this to the file:// syntax?
lgtm
comments addressed
On 2016/04/20 19:04:12, DaleCurtis wrote: > Should we switch this to the file:// syntax? Good point. Done.
The CQ bit was checked by xhwang@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1905473002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1905473002/60001
lgtm
The CQ bit was unchecked by xhwang@chromium.org
The CQ bit was checked by xhwang@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from sandersd@chromium.org Link to the patchset: https://codereview.chromium.org/1905473002/#ps60001 (title: "comments addressed")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1905473002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1905473002/60001
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== media: Add liberato and watk as media/gpu android owners ========== to ========== media: Add liberato and watk as media/gpu android owners Committed: https://crrev.com/0ce639dc8be23e67c7eb33f00ed6d16d60865437 Cr-Commit-Position: refs/heads/master@{#388632} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/0ce639dc8be23e67c7eb33f00ed6d16d60865437 Cr-Commit-Position: refs/heads/master@{#388632} |
