Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1905463002:
Use lazy registration in Polymer UI. (Closed)
DescriptionUse lazy registration in Polymer UI.
Speed-up on the Basic and Advanced MD Settings pages
(no sub-pages) with N=10 on a Z840:
Basic Advanced
Linux 12.8% 18.9%
CrOS 7.5% 12.4%
BUG=597347
Committed: https://crrev.com/014be79bc324f0e91230db4ad18b253de0301b91
Cr-Commit-Position: refs/heads/master@{#389375}
Patch Set 1 #Patch Set 2 : rebase #Patch Set 3 : rebase #
Messages
Total messages: 22 (10 generated)
michaelpg@chromium.org changed reviewers: + dbeam@chromium.org
Will run performance tests tonight.
can you quantify why we're doing this?
On 2016/04/19 21:58:41, Dan Beam wrote: > can you quantify why we're doing this? see initial message. feel free to hold off until I post the numbers
Description was changed from
==========
Use lazy registration in Polymer UI.
BUG=597347
==========
to
==========
Use lazy registration in Polymer UI.
Speed-up on the Basic and Advanced MD Settings pages
(no sub-pages) with N=10 on a Z840:
Basic Advanced
Linux 12.8% 18.9%
CrOS 7.5% 12.4%
BUG=597347
==========
Published stats, they're pretty good.
lgtm
The CQ bit was checked by michaelpg@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1905463002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1905463002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by michaelpg@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1905463002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1905463002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by michaelpg@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org Link to the patchset: https://codereview.chromium.org/1905463002/#ps40001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1905463002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1905463002/40001
Message was sent while issue was closed.
Description was changed from
==========
Use lazy registration in Polymer UI.
Speed-up on the Basic and Advanced MD Settings pages
(no sub-pages) with N=10 on a Z840:
Basic Advanced
Linux 12.8% 18.9%
CrOS 7.5% 12.4%
BUG=597347
==========
to
==========
Use lazy registration in Polymer UI.
Speed-up on the Basic and Advanced MD Settings pages
(no sub-pages) with N=10 on a Z840:
Basic Advanced
Linux 12.8% 18.9%
CrOS 7.5% 12.4%
BUG=597347
==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from
==========
Use lazy registration in Polymer UI.
Speed-up on the Basic and Advanced MD Settings pages
(no sub-pages) with N=10 on a Z840:
Basic Advanced
Linux 12.8% 18.9%
CrOS 7.5% 12.4%
BUG=597347
==========
to
==========
Use lazy registration in Polymer UI.
Speed-up on the Basic and Advanced MD Settings pages
(no sub-pages) with N=10 on a Z840:
Basic Advanced
Linux 12.8% 18.9%
CrOS 7.5% 12.4%
BUG=597347
Committed: https://crrev.com/014be79bc324f0e91230db4ad18b253de0301b91
Cr-Commit-Position: refs/heads/master@{#389375}
==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/014be79bc324f0e91230db4ad18b253de0301b91 Cr-Commit-Position: refs/heads/master@{#389375} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
