Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(971)

Issue 1905433002: Add documentation for exec_script and gypi_to_gn (Closed)

Created:
4 years, 8 months ago by brettw
Modified:
4 years, 8 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add documentation for exec_script and gypi_to_gn There have been several questions about this recently. Committed: https://crrev.com/d385ecffc8fbe77cdb5e8b839896291a53b1c988 Cr-Commit-Position: refs/heads/master@{#388341}

Patch Set 1 #

Total comments: 1

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -1 line) Patch
M .gn View 1 1 chunk +59 lines, -1 line 0 comments Download
M build/gypi_to_gn.py View 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
brettw
4 years, 8 months ago (2016-04-19 20:13:33 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1905433002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1905433002/1
4 years, 8 months ago (2016-04-19 20:14:03 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-19 21:03:31 UTC) #6
Dirk Pranke
lgtm https://codereview.chromium.org/1905433002/diff/1/.gn File .gn (right): https://codereview.chromium.org/1905433002/diff/1/.gn#newcode166 .gn:166: # - It's myserious what causes some things ...
4 years, 8 months ago (2016-04-19 21:36:06 UTC) #7
brettw
.
4 years, 8 months ago (2016-04-19 21:47:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1905433002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1905433002/20001
4 years, 8 months ago (2016-04-19 21:48:18 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-19 22:53:32 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:17:33 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d385ecffc8fbe77cdb5e8b839896291a53b1c988
Cr-Commit-Position: refs/heads/master@{#388341}

Powered by Google App Engine
This is Rietveld 408576698