Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 190543012: cc: Don't call ReadyToFinalizeTextureUpdates multiple times (Closed)

Created:
6 years, 9 months ago by brianderson
Modified:
6 years, 9 months ago
Reviewers:
reveman
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

cc: Don't call ReadyToFinalizeTextureUpdates multiple times Today, NotifyReadyToCommit always results in an immediate commit. However, if we start commits early and have to throttle commits such that NotifyReadyToCommit doesn't result in an immediate commit, we might receive multiple calls to NotifyReadyToCommit because it is possilbe that ResourceUpdateControler might call ReadyToFinalizeTextureUpdates multiple times before we finish the commit. BUG=293941 TEST=ResourceUpdateControllerTest_NoMoreUpdates Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=256190

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -6 lines) Patch
M cc/resources/resource_update_controller.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/resources/resource_update_controller.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M cc/resources/resource_update_controller_unittest.cc View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
brianderson
ptal This is needed for me to land https://codereview.chromium.org/23907006
6 years, 9 months ago (2014-03-10 19:01:35 UTC) #1
reveman
lgtm
6 years, 9 months ago (2014-03-10 20:19:48 UTC) #2
brianderson
The CQ bit was checked by brianderson@chromium.org
6 years, 9 months ago (2014-03-10 20:20:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brianderson@chromium.org/190543012/1
6 years, 9 months ago (2014-03-10 20:24:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brianderson@chromium.org/190543012/1
6 years, 9 months ago (2014-03-10 21:48:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brianderson@chromium.org/190543012/1
6 years, 9 months ago (2014-03-10 22:30:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brianderson@chromium.org/190543012/1
6 years, 9 months ago (2014-03-10 23:46:02 UTC) #7
commit-bot: I haz the power
6 years, 9 months ago (2014-03-11 11:06:25 UTC) #8
Message was sent while issue was closed.
Change committed as 256190

Powered by Google App Engine
This is Rietveld 408576698