Issue 1905423003: [Merged] media: Properly tell whether the buffer is encrypted

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1905423003: [Merged] media: Properly tell whether the buffer is encrypted (Closed)

Created:
4 years, 8 months ago by Tima Vaisburd

Modified:
4 years, 8 months ago

Reviewers:
timav

CC:
chromium-reviews, feature-media-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@2704

Target Ref:
refs/pending/branch-heads/2704

Project:
chromium

Visibility:
Public.

[Merged] media: Properly tell whether the buffer is encrypted We need to call MediaCodec method queueSecureInputBuffer() instead of queueInputBuffer() only if both the key and the initialization vector are not empty. BUG=605341 TBR=timav > Review URL: https://codereview.chromium.org/1912213002 > Cr-Commit-Position: refs/heads/master@{#389229} Committed: https://chromium.googlesource.com/chromium/src/+/90dcdd907a4050acb00d9c878dafc3402d7c347c

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	media/base/decrypt_config.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
	M	media/filters/android/media_codec_audio_decoder.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (1 generated)

Tima Vaisburd

4 years, 8 months ago (2016-04-22 21:38:55 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
90dcdd907a4050acb00d9c878dafc3402d7c347c.