Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Issue 1905423002: Leak VariationsParamAssociator (Closed)

Created:
4 years, 8 months ago by Patrick Monette
Modified:
4 years, 8 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Leak VariationsParamAssociator This will allow tasks posted with CONTINUE_ON_SHUTDOWN to access varitions parameters since these task can outlive non-leaky singletons that are registered to be deleted with the AtExitManager. The bigger picture is that we want to remove the number of tasks labeled with SKIP_ON_SHUTDOWN because they can potentially cause a shutdown hang. BUG=478209 Committed: https://crrev.com/9f330b920cd5604eab3eb21ddd522be7921f30a0 Cr-Commit-Position: refs/heads/master@{#389183}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M components/variations/variations_associated_data.cc View 1 chunk +3 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (5 generated)
Patrick Monette
This is the change we discussed in person. PTAL
4 years, 8 months ago (2016-04-22 17:35:11 UTC) #3
Alexei Svitkine (slow)
lgtm
4 years, 8 months ago (2016-04-22 17:37:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1905423002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1905423002/1
4 years, 8 months ago (2016-04-22 17:38:40 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-22 18:45:50 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:50:28 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9f330b920cd5604eab3eb21ddd522be7921f30a0
Cr-Commit-Position: refs/heads/master@{#389183}

Powered by Google App Engine
This is Rietveld 408576698