Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6720)

Unified Diff: chrome/browser/ui/browser_instant_controller.cc

Issue 19054012: Reload Local NTP on default search provider change. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: '' Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser_instant_controller.cc
diff --git a/chrome/browser/ui/browser_instant_controller.cc b/chrome/browser/ui/browser_instant_controller.cc
index b1454e8cb97f816529db3f6c3403b7dab459a017..4adeb91e49e80da1f2bbb0fc1471246b47bfe163 100644
--- a/chrome/browser/ui/browser_instant_controller.cc
+++ b/chrome/browser/ui/browser_instant_controller.cc
@@ -261,15 +261,6 @@ void BrowserInstantController::OnDefaultSearchProviderChanged(
if (!contents)
continue;
- // A Local NTP always runs in the Instant process, so reloading it is
- // neither useful nor necessary. However, the Local NTP does not reflect
- // whether Google is the default search engine or not. This is achieved
- // through a URL parameter, so reloading the existing URL won't fix that
- // (i.e., the Local NTP may now show an incorrect search engine logo).
- // TODO(kmadhusu): Fix.
- if (contents->GetURL() == GURL(chrome::kChromeSearchLocalNtpUrl))
- continue;
-
if (!instant_service->IsInstantProcess(
contents->GetRenderProcessHost()->GetID()))
continue;

Powered by Google App Engine
This is Rietveld 408576698