Reload Local NTP on default search provider change.

chrome/browser/resources/local_ntp/local_ntp.js

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 
 /**
  * @fileoverview The local InstantExtended NTP.
  */
 
 /**
  * Controls rendering the new tab page for InstantExtended.
- * @param {Object} location window.location or a mock.
+ * @param {Object} testData Mock data to test the local NTP.
  * @return {Object} A limited interface for testing the local NTP.
  */
-function LocalNTP(location) {
+function LocalNTP(testData) {
 <include src="../../../../ui/webui/resources/js/assert.js">
 
 
 
 /**
  * Enum for classnames.
  * @enum {string}
  * @const
  */
 var CLASSES = {
@@ skipping 220 matching lines @@
 
 /** @type {number} @const */
 var MAX_NUM_COLUMNS = 4;
 
 
 /** @type {number} @const */
 var NUM_ROWS = 2;
 
 
 /**
+ * Mock data to test the local NTP.
+ * @type {Object}
+ * const
+ * */
+var mockTestData = testData;
+
+/**
  * Minimum total padding to give to the left and right of the most visited
  * section. Used to determine how many tiles to show.
  * @type {number}
  * @const
  */
 var MIN_TOTAL_HORIZONTAL_PADDING = 200;
 
 
 /**
  * The filename for a most visited iframe src which shows a page title.
@@ skipping 605 matching lines @@
     return window.chrome.embeddedSearch;
   return null;
 }
 
 
 /**
  * @return {boolean} True if this is a Google page and not some other search
  *     provider. Used to determine whether to show the logo and fakebox.
  */
 function isGooglePage() {
-  return location.href.indexOf('isGoogle') != -1;
+  if (window.localNTPUnitTest && mockTestData)

[samarth, 2013/07/12 17:16:06]

Having a separate code path for the test kind of defeats the purpose of the test
:)

Can you instead make a test-config.js file that you construct by hand?

[kmadhusu, 2013/07/15 22:21:51]

Fixed. Instead of modifying the codepath, I updated "configData.isGooglePage"
value in local_ntp_browsertest.js.

+    return mockTestData.isGooglePage;
+
+  return templateData.isGooglePage;
 }
 
 
 /**
  * Extract the desired navigation behavior from a click button.
  * @param {number} button The Event#button property of a click event.
  * @return {WindowOpenDisposition} The desired behavior for
  *     navigateContentWindow.
  */
 function getDispositionFromClickButton(button) {
@@ skipping 13 matching lines @@
   notification = $(IDS.NOTIFICATION);
   attribution = $(IDS.ATTRIBUTION);
   ntpContents = $(IDS.NTP_CONTENTS);
 
   for (var i = 0; i < NUM_ROWS; i++) {
     var row = document.createElement('div');
     row.classList.add(CLASSES.ROW);
     tilesContainer.appendChild(row);
   }
 
   if (isGooglePage()) {

[samarth, 2013/07/12 17:16:06]

This is now simple enough that I would just inline the call to isGooglePage here
and get rid of the function.

[kmadhusu, 2013/07/15 22:21:51]

Done.

     var logo = document.createElement('div');
     logo.id = IDS.LOGO;
 
     fakebox = document.createElement('div');
     fakebox.id = IDS.FAKEBOX;
     fakebox.innerHTML =
         '<input autocomplete="off" tabindex="-1" aria-hidden="true">' +
         '<div id=cursor></div>';
 
     ntpContents.insertBefore(fakebox, ntpContents.firstChild);
@@ skipping 81 matching lines @@
   document.addEventListener('DOMContentLoaded', init);
 }
 
 return {
   init: init,
   listen: listen
 };
 }
 
 if (!window.localNTPUnitTest) {
-  LocalNTP(location).listen();
+  LocalNTP(undefined).listen();
 }