Reload Local NTP on default search provider change.

chrome/browser/search/search.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/search/search.h"
 
 #include "base/command_line.h"
 #include "base/metrics/field_trial.h"
 #include "base/metrics/histogram.h"
 #include "base/prefs/pref_service.h"
@@ skipping 330 matching lines @@
   if (instant_url.SchemeIsSecure() ||
       google_util::StartsWithCommandLineGoogleBaseURL(instant_url))
     return instant_url;
   GURL::Replacements replacements;
   const std::string secure_scheme(chrome::kHttpsScheme);
   replacements.SetSchemeStr(secure_scheme);
   return instant_url.ReplaceComponents(replacements);
 }
 
 GURL GetLocalInstantURL(Profile* profile) {
+  return GURL(chrome::kChromeSearchLocalNtpUrl);
+}
+
+bool DefaultSearchProviderIsGoogle(Profile* profile) {
+  DCHECK(profile);

[samarth, 2013/07/17 16:39:45]

All the other functions in this file don't enforce that a passed-in Profile is
non-NULL. You could just return false here.

[kmadhusu, 2013/07/17 17:58:03]

Done.

   const TemplateURL* default_provider =
       GetDefaultSearchProviderTemplateURL(profile);
 
-  if (default_provider &&
+  return default_provider &&
       (TemplateURLPrepopulateData::GetEngineType(default_provider->url()) ==
-       SEARCH_ENGINE_GOOGLE)) {
-    return GURL(chrome::kChromeSearchLocalGoogleNtpUrl);
-  }
-  return GURL(chrome::kChromeSearchLocalNtpUrl);
+       SEARCH_ENGINE_GOOGLE);
 }
 
 bool ShouldPreferRemoteNTPOnStartup() {
   // Check the command-line/about:flags setting first, which should have
   // precedence and allows the trial to not be reported (if it's never queried).
   const CommandLine* command_line = CommandLine::ForCurrentProcess();
   if (command_line->HasSwitch(switches::kDisableInstantExtendedAPI) ||
       command_line->HasSwitch(switches::kEnableLocalFirstLoadNTP)) {
     return false;
   }
@@ skipping 172 matching lines @@
                                     bool default_value,
                                     const FieldTrialFlags& flags) {
   return !!GetUInt64ValueForFlagWithDefault(flag, default_value ? 1 : 0, flags);
 }
 
 void ResetInstantExtendedOptInStateGateForTest() {
   instant_extended_opt_in_state_gate = false;
 }
 
 }  // namespace chrome