Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(549)

Issue 1905393002: [ios] Added WebState::GetLoadingProgress web// API. (Closed)

Created:
4 years, 8 months ago by Eugene But (OOO till 7-30)
Modified:
4 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Added WebState::GetLoadingProgress web// API. This API is necessary to remove loading progress code from Tab, which is currently stores the loading progress and provides it to Toolbar. Corresponding method does not exist in WebContents, because on Desktop the progress is not shown in UI and on Android progress is stored in WebContentsDelegateAndroid. BUG=None Committed: https://crrev.com/ec7db8a2d1757e5d99200d12147d5a3e77d474e0 Cr-Commit-Position: refs/heads/master@{#389887}

Patch Set 1 #

Patch Set 2 : Self review #

Patch Set 3 : Added missing method #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -0 lines) Patch
M ios/web/public/test/test_web_state.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ios/web/public/test/test_web_state.mm View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M ios/web/public/web_state/web_state.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/web/web_state/ui/crw_web_controller.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M ios/web/web_state/ui/crw_web_controller.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/web/web_state/web_state_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M ios/web/web_state/web_state_impl.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/web/web_state/web_state_impl_unittest.mm View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
Eugene But (OOO till 7-30)
4 years, 7 months ago (2016-04-25 14:02:08 UTC) #4
Eugene But (OOO till 7-30)
Kurt is out. Jackie could you please take a look.
4 years, 7 months ago (2016-04-26 20:00:32 UTC) #6
kkhorimoto
Sorry for the delay, but lgtm. I think we should remove the link to the ...
4 years, 7 months ago (2016-04-26 20:04:32 UTC) #7
Eugene But (OOO till 7-30)
On 2016/04/26 20:04:32, kkhorimoto_ wrote: > Sorry for the delay, but lgtm. I think we ...
4 years, 7 months ago (2016-04-26 20:13:50 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1905393002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1905393002/40001
4 years, 7 months ago (2016-04-26 20:14:08 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-04-26 21:15:53 UTC) #13
commit-bot: I haz the power
4 years, 7 months ago (2016-04-26 21:16:52 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/ec7db8a2d1757e5d99200d12147d5a3e77d474e0
Cr-Commit-Position: refs/heads/master@{#389887}

Powered by Google App Engine
This is Rietveld 408576698