Resize video output to match input dimensions.

Resize video output to match input dimensions.

Prevents bug where VGA output was compared to HD input, causing very low
SSIM/PSNR scores.

BUG=chromium:605867
R=phoglund@chromium.org
NOTRY=true

Committed: https://crrev.com/e25e8204e8135c1336f703b7962c2656cbb5b52f
Cr-Commit-Position: refs/heads/master@{#389096}

[pbos, 2016-04-22 13:46:13]

PTAL

[phoglund_chromium, 2016-04-22 13:58:30]

lgtm, nits

https://codereview.chromium.org/1905373002/diff/1/chrome/test/data/webrtc/vid...
File chrome/test/data/webrtc/video_extraction.js (right):

https://codereview.chromium.org/1905373002/diff/1/chrome/test/data/webrtc/vid...
chrome/test/data/webrtc/video_extraction.js:55: // Resize output element to
input dimensions to not compare VGA output to HD
That doesn't explain the background. What about:

// The WebRTC code is free to start in VGA, so make sure that the output
// video tag scales up to whatever the input size is (otherwise the video
// quality comparison will go poorly.

Also move the comment to above videoTag.width = width;

[pbos, 2016-04-22 14:00:55]

updated comment

[pbos, 2016-04-22 14:04:36]

moved comment

[pbos, 2016-04-22 14:04:42]

https://codereview.chromium.org/1905373002/diff/1/chrome/test/data/webrtc/vid...
File chrome/test/data/webrtc/video_extraction.js (right):

https://codereview.chromium.org/1905373002/diff/1/chrome/test/data/webrtc/vid...
chrome/test/data/webrtc/video_extraction.js:55: // Resize output element to
input dimensions to not compare VGA output to HD
On 2016/04/22 13:58:30, phoglund_chrome wrote:
> That doesn't explain the background. What about:
> 
> // The WebRTC code is free to start in VGA, so make sure that the output
> // video tag scales up to whatever the input size is (otherwise the video
> // quality comparison will go poorly.
> 
> Also move the comment to above videoTag.width = width;

Done.

[pbos, 2016-04-22 14:10:18]

Description was changed from

==========
Resize video output to match input dimensions.

Prevents bug where VGA output was compared to HD input, causing very low
SSIM/PSNR scores.

BUG=chromium:605867
R=phoglund@chromium.org
==========

to

==========
Resize video output to match input dimensions.

Prevents bug where VGA output was compared to HD input, causing very low
SSIM/PSNR scores.

BUG=chromium:605867
R=phoglund@chromium.org
NOTRY=True
==========

[pbos, 2016-04-22 14:10:52]

Description was changed from

==========
Resize video output to match input dimensions.

Prevents bug where VGA output was compared to HD input, causing very low
SSIM/PSNR scores.

BUG=chromium:605867
R=phoglund@chromium.org
NOTRY=True
==========

to

==========
Resize video output to match input dimensions.

Prevents bug where VGA output was compared to HD input, causing very low
SSIM/PSNR scores.

BUG=chromium:605867
R=phoglund@chromium.org
NOTRY=true
==========

[pbos, 2016-04-22 14:10:57]

The CQ bit was checked by pbos@chromium.org

[pbos, 2016-04-22 14:10:57]

The patchset sent to the CQ was uploaded after l-g-t-m from
phoglund@chromium.org
Link to the patchset: https://codereview.chromium.org/1905373002/#ps40001
(title: "moved comment")

[commit-bot: I haz the power, 2016-04-22 14:11:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1905373002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1905373002/40001

[commit-bot: I haz the power, 2016-04-22 14:14:37]

Description was changed from

==========
Resize video output to match input dimensions.

Prevents bug where VGA output was compared to HD input, causing very low
SSIM/PSNR scores.

BUG=chromium:605867
R=phoglund@chromium.org
NOTRY=true
==========

to

==========
Resize video output to match input dimensions.

Prevents bug where VGA output was compared to HD input, causing very low
SSIM/PSNR scores.

BUG=chromium:605867
R=phoglund@chromium.org
NOTRY=true
==========

[commit-bot: I haz the power, 2016-04-22 14:14:40]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-22 19:47:02]

Description was changed from

==========
Resize video output to match input dimensions.

Prevents bug where VGA output was compared to HD input, causing very low
SSIM/PSNR scores.

BUG=chromium:605867
R=phoglund@chromium.org
NOTRY=true
==========

to

==========
Resize video output to match input dimensions.

Prevents bug where VGA output was compared to HD input, causing very low
SSIM/PSNR scores.

BUG=chromium:605867
R=phoglund@chromium.org
NOTRY=true

Committed: https://crrev.com/e25e8204e8135c1336f703b7962c2656cbb5b52f
Cr-Commit-Position: refs/heads/master@{#389096}
==========

[commit-bot: I haz the power, 2016-04-22 19:47:03]

Patchset 3 (id:??) landed as
https://crrev.com/e25e8204e8135c1336f703b7962c2656cbb5b52f
Cr-Commit-Position: refs/heads/master@{#389096}