Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 1905353002: Use a tokenizer to parse the command line for applications. (Closed)

Created:
4 years, 8 months ago by etiennej
Modified:
4 years, 8 months ago
Reviewers:
qsr, ppi
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Use a tokenizer to parse the command line for applications. This enables the use of spaces within arguments, as those can now be quoted. R=ppi@chromium.org, ppi, qsr Committed: https://chromium.googlesource.com/external/mojo/+/a627834040bfe61f30602813a5fc19192a2dc6fb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -5 lines) Patch
M shell/command_line_util.cc View 2 chunks +9 lines, -2 lines 0 comments Download
M shell/command_line_util_unittest.cc View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
etiennej
4 years, 8 months ago (2016-04-22 13:30:32 UTC) #1
ppi
lgtm
4 years, 8 months ago (2016-04-22 13:32:18 UTC) #2
etiennej
4 years, 8 months ago (2016-04-22 13:46:11 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a627834040bfe61f30602813a5fc19192a2dc6fb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698