third_party/WebKit/Source/modules/webaudio/OfflineAudioDestinationNode.cpp - Issue 1905343002: Replace AllowCrossThreadAccess() + ThreadSafeRefCounted pointers with PassRefPtr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webaudio/OfflineAudioDestinationNode.cpp

Issue 1905343002: Replace AllowCrossThreadAccess() + ThreadSafeRefCounted pointers with PassRefPtr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Kuroneko_3_DoNotAllow_AllowCrossThreadAccess_GCed

Patch Set: Rebase. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/webaudio/MediaElementAudioSourceNode.cpp ('K') | « third_party/WebKit/Source/modules/webaudio/MediaElementAudioSourceNode.cpp ('k') | third_party/WebKit/Source/modules/webaudio/ScriptProcessorNode.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webaudio/OfflineAudioDestinationNode.cpp

diff --git a/third_party/WebKit/Source/modules/webaudio/OfflineAudioDestinationNode.cpp b/third_party/WebKit/Source/modules/webaudio/OfflineAudioDestinationNode.cpp

index 29a9bce846898a5ce84df48aaa46c0a7f07f7843..04edef246c88b263001690a05ddc2576e0642008 100644

--- a/third_party/WebKit/Source/modules/webaudio/OfflineAudioDestinationNode.cpp

+++ b/third_party/WebKit/Source/modules/webaudio/OfflineAudioDestinationNode.cpp

@@ -203,10 +203,7 @@ void OfflineAudioDestinationHandler::suspendOfflineRendering()

if (context()->getExecutionContext()) {

context()->getExecutionContext()->postTask(

BLINK_FROM_HERE,

- createCrossThreadTask(

- &OfflineAudioDestinationHandler::notifySuspend,

- this,

- context()->currentSampleFrame()));

+ createCrossThreadTask(&OfflineAudioDestinationHandler::notifySuspend, PassRefPtr<OfflineAudioDestinationHandler>(this), context()->currentSampleFrame()));

hiroshige 2016/05/17 03:46:12 ditto.

}

@@ -217,7 +214,7 @@ void OfflineAudioDestinationHandler::finishOfflineRendering()

// The actual rendering has been completed. Notify the context.

if (context()->getExecutionContext()) {

context()->getExecutionContext()->postTask(BLINK_FROM_HERE,

- createCrossThreadTask(&OfflineAudioDestinationHandler::notifyComplete, AllowCrossThreadAccess(this)));

+ createCrossThreadTask(&OfflineAudioDestinationHandler::notifyComplete, PassRefPtr<OfflineAudioDestinationHandler>(this)));

}