Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 190533009: mac: Let task manager use IDR_PRODUCT_LOGO_16 instead of NSApplicationIcon. (Closed)

Created:
6 years, 9 months ago by Nico
Modified:
6 years, 9 months ago
Reviewers:
viettrungluu
CC:
chromium-reviews, rsesek+watch_chromium.org
Visibility:
Public.

Description

mac: Let task manager use IDR_PRODUCT_LOGO_16 instead of NSApplicationIcon. According to `purge; sample -wait Chromium` and launching out/Release/Chromium.app/Contents/MacOS with 30 wikipedia tabs, this reduces time spent creating the TaskManagerModel (which happens on the IO thread, in response to raw bytes arriving from the network) from ~100 samples to ~1 sample. The icon looks slightly different from the icon that Activity Monitor displays, but a) it looks arguably nicer now (sharp) and b) most people never open the task manager. BUG=none NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255797

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -19 lines) Patch
M chrome/browser/task_manager/browser_process_resource_provider.cc View 1 chunk +1 line, -9 lines 0 comments Download
M ui/gfx/image/image_skia_util_mac.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/gfx/image/image_skia_util_mac.mm View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
viettrungluu
WAT LGTM
6 years, 9 months ago (2014-03-08 02:30:03 UTC) #1
Nico
The CQ bit was checked by thakis@chromium.org
6 years, 9 months ago (2014-03-08 02:38:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/190533009/1
6 years, 9 months ago (2014-03-08 11:19:53 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-08 14:06:10 UTC) #4
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) telemetry_perf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=234367
6 years, 9 months ago (2014-03-08 14:06:10 UTC) #5
Nico
The CQ bit was checked by thakis@chromium.org
6 years, 9 months ago (2014-03-08 21:11:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/190533009/1
6 years, 9 months ago (2014-03-08 21:12:00 UTC) #7
commit-bot: I haz the power
6 years, 9 months ago (2014-03-08 21:12:35 UTC) #8
Message was sent while issue was closed.
Change committed as 255797

Powered by Google App Engine
This is Rietveld 408576698