Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5845)

Unified Diff: chrome/browser/extensions/api/app_window/app_window_apitest.cc

Issue 190533006: Add support for transparent background API (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Wrap Missing Permission string in #ifdef AURA Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/app_window/app_window_apitest.cc
diff --git a/chrome/browser/extensions/api/app_window/app_window_apitest.cc b/chrome/browser/extensions/api/app_window/app_window_apitest.cc
index 8b581579e74b861cf0a42b9a310eedd4cf17eb39..746ffda314256ec0deb870b815331bfcad01a710 100644
--- a/chrome/browser/extensions/api/app_window/app_window_apitest.cc
+++ b/chrome/browser/extensions/api/app_window/app_window_apitest.cc
@@ -108,4 +108,24 @@ IN_PROC_BROWSER_TEST_F(PlatformAppBrowserTest, WindowsApiGet) {
<< message_;
}
+IN_PROC_BROWSER_TEST_F(PlatformAppBrowserTest,
+ WindowsApiAlphaEnabledHasPermissions) {
benwells 2014/05/12 04:25:17 Please also add a test for running this in stable
garykac 2014/07/09 23:19:21 Done, but on Stable requesting app.window.shape pr
+#if defined(USE_AURA)
benwells 2014/05/12 04:25:17 So ... if aura is enabled, alphaEnabled will be tr
garykac 2014/07/09 23:19:21 Changed all the #ifdefs to use USE_ASH.
+ EXPECT_TRUE(RunPlatformAppTest(
+ "platform_apps/windows_api_alpha_enabled/has_permissions_aura"))
+ << message_;
+#else
+ EXPECT_TRUE(RunPlatformAppTest(
+ "platform_apps/windows_api_alpha_enabled/has_permissions_no_aura"))
+ << message_;
+#endif
+}
+
+IN_PROC_BROWSER_TEST_F(PlatformAppBrowserTest,
+ WindowsApiAlphaEnabledNoPermissions) {
+ EXPECT_TRUE(RunPlatformAppTest(
+ "platform_apps/windows_api_alpha_enabled/no_permissions"))
+ << message_;
+}
+
} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698