Add support for transparent background API

chrome/browser/extensions/api/app_window/app_window_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/app_window/app_window_api.h"
 
 #include "apps/app_window.h"
 #include "apps/app_window_contents.h"
 #include "apps/app_window_registry.h"
 #include "apps/apps_client.h"
@@ skipping 32 matching lines @@
     "The window id can not be more than 256 characters long.";
 const char kInvalidColorSpecification[] =
     "The color specification could not be parsed.";
 const char kInvalidChannelForFrameOptions[] =
     "Frame options are only available in dev channel.";
 const char kColorWithFrameNone[] = "Windows with no frame cannot have a color.";
 const char kInactiveColorWithoutColor[] =
     "frame.inactiveColor must be used with frame.color.";
 const char kConflictingBoundsOptions[] =
     "The $1 property cannot be specified for both inner and outer bounds.";
+
+#if defined(USE_AURA)
+const char kMissingPermissionAlphaEnabled[] =
+    "The alphaEnabled option requires app.window.alpha permission.";
+#endif
 }  // namespace app_window_constants
 
 const char kNoneFrameOption[] = "none";
   // TODO(benwells): Remove HTML titlebar injection.
 const char kHtmlFrameOption[] = "experimental-html";
 
 namespace {
 
 // Opens an inspector window and delays the response to the
 // AppWindowCreateFunction until the DevToolsWindow has finished loading, and is
@@ skipping 153 matching lines @@
     if (GetCurrentChannel() <= chrome::VersionInfo::CHANNEL_DEV ||
         GetExtension()->location() == extensions::Manifest::COMPONENT) {
       if (options->type == extensions::api::app_window::WINDOW_TYPE_PANEL) {
         create_params.window_type = AppWindow::WINDOW_TYPE_PANEL;
       }
     }
 
     if (!GetFrameOptions(*options, &create_params))
       return false;
 
-    if (options->transparent_background.get() &&
-        (GetExtension()->HasAPIPermission(APIPermission::kExperimental) ||
-         CommandLine::ForCurrentProcess()->HasSwitch(
-             switches::kEnableExperimentalExtensionApis))) {
-      create_params.transparent_background = *options->transparent_background;
+#if defined(USE_AURA)

[benwells, 2014/05/12 04:25:17]

Why is this gated on aura? If you try to use this on another platform and don't
have the permission, you should get the same error.

[garykac, 2014/07/09 23:19:21]

Done.

+    if (options->alpha_enabled.get()) {
+      bool allow_alpha_enabled = false;
+      // For now, continue to support this if Experimental is set (any channel).
+      // TODO(garykac) Remove this once the permission moves to stable.
+      if (GetExtension()->HasAPIPermission(APIPermission::kExperimental) ||

[benwells, 2014/05/12 04:25:17]

After thinking about it I'd prefer to remove access via experimental flag since
we're restricting to dev channel. Are there real apps you know you'll break?

[garykac, 2014/07/09 23:19:21]

I don't know of any apps. Removed.

+          CommandLine::ForCurrentProcess()->HasSwitch(
+              switches::kEnableExperimentalExtensionApis)) {
+        allow_alpha_enabled = true;
+      }
+      // Support alphaEnabled permission on dev channel.
+      if (GetCurrentChannel() <= chrome::VersionInfo::CHANNEL_DEV) {

[benwells, 2014/05/12 04:25:17]

There should also be an error if the user tries to access this and they are on
stable / beta.

[garykac, 2014/07/09 23:19:21]

Done. Handled in the _permission_features.json.

+        if (GetExtension()->HasAPIPermission(APIPermission::kAlphaEnabled)) {
+          allow_alpha_enabled = true;
+        } else {
+          error_ = app_window_constants::kMissingPermissionAlphaEnabled;
+          return false;
+        }
+      }
+      if (allow_alpha_enabled) {
+        create_params.alpha_enabled = *options->alpha_enabled;
+      }
     }
+#endif
 
     if (options->hidden.get())
       create_params.hidden = *options->hidden.get();
 
     if (options->resizable.get())
       create_params.resizable = *options->resizable.get();
 
     if (options->always_on_top.get() &&
         GetExtension()->HasAPIPermission(APIPermission::kAlwaysOnTopWindows))
       create_params.always_on_top = *options->always_on_top.get();
@@ skipping 250 matching lines @@
     // TODO(benwells): Remove this code once we get agreement to use the new
     // native style frame.
     create_params->has_frame_color = true;
     create_params->active_frame_color = SK_ColorWHITE;
     create_params->inactive_frame_color = SK_ColorWHITE;
   }
 #endif
 }
 
 }  // namespace extensions