Issue 19053002: Promote exceptions thrown inside failed-access-check callback.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19053002: Promote exceptions thrown inside failed-access-check callback. (Closed)

Created:
7 years, 5 months ago by Yang

Modified:
7 years, 5 months ago

Reviewers:
Mike West

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Promote exceptions thrown inside failed-access-check callback. BUG=v8:2524

Patch Set 1 #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+180 lines, -26 lines)			Patch
M	src/handles.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/objects.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/objects.cc	View	11 chunks	+13 lines, -2 lines	0 comments	Download
M	src/runtime.cc	View	14 chunks	+40 lines, -23 lines	0 comments	Download
M	test/cctest/test-api.cc	View	1 chunk	+122 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Yang

Like discussed, this is the proposed fix for the Security Exception issue. I'll have to ...

7 years, 5 months ago (2013-07-11 15:41:43 UTC) #1

Mike West

On 2013/07/11 15:41:43, Yang wrote: > Like discussed, this is the proposed fix for the ...

7 years, 5 months ago (2013-07-12 07:46:54 UTC) #2

Yang

7 years, 5 months ago (2013-07-12 11:16:30 UTC) #3

On 2013/07/12 07:46:54, Mike West wrote:
> On 2013/07/11 15:41:43, Yang wrote:
> > Like discussed, this is the proposed fix for the Security Exception issue.
> I'll
> > have to go over it a second time and probably add some more test coverage,
but
> > it would be great to see whether it works as intended.
> 
> This looks like it enables the correct behavior when I apply the patch from
> https://codereview.chromium.org/18661005/. The output LGTM, but you'll
obviously
> need someone who knows anything about V8 to review the actual implementation.
:)
> 
> Thank you!

Closing this issue. The rebased version is here:
https://codereview.chromium.org/18298012/

Expand Messages | Collapse Messages