chrome/browser/browser_hangs_experiment.h - Issue 1905293003: Use CONTINUE_ON_SHUTDOWN for IncidentReportingService tasks.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/browser_hangs_experiment.h

Issue 1905293003: Use CONTINUE_ON_SHUTDOWN for IncidentReportingService tasks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_BROWSER_HANGS_EXPERIMENT_H_

	6 #define CHROME_BROWSER_BROWSER_HANGS_EXPERIMENT_H_

	7

	8 // In order to demonstrate the impact of fixing hang bugs in relation to the
	grt (UTC plus 2) 2016/04/25 13:37:53 nit: Fixes for browser hang bugs are deployed in nit: Fixes for browser hang bugs are deployed in a field trial in order to measure their impact. Patrick Monette 2016/04/25 18:14:27 Done. Show quoted text On 2016/04/25 13:37:53, grt wrote: > nit: > > Fixes for browser hang bugs are deployed in a field trial in order to measure > their impact. Done.
	9 // number of unclean shutdown, those fixes are going to be behind a finch

	10 // experiment.
	manzagop (departed) 2016/04/25 13:37:39 Reference the bug number? Reference the bug number? Patrick Monette 2016/04/25 18:14:27 Done. Show quoted text On 2016/04/25 13:37:39, manzagop wrote: > Reference the bug number? Done.
	11

	12 // Returns true if the experimentation is enabled.

	13 bool IsBrowserHangsExperimentEnabled();
	manzagop (departed) 2016/04/25 13:37:39 Wdyt of IsBrowserHangFixesExperimentEnabled to avo Wdyt of IsBrowserHangFixesExperimentEnabled to avoid misinterpretation? Please push back if you think it's overboard. Patrick Monette 2016/04/25 18:14:27 Done. Show quoted text On 2016/04/25 13:37:39, manzagop wrote: > Wdyt of IsBrowserHangFixesExperimentEnabled to avoid misinterpretation? Please > push back if you think it's overboard. Done.
	14

	15 #endif // CHROME_BROWSER_BROWSER_HANGS_EXPERIMENT_H_

OLD	NEW

« no previous file with comments | « no previous file | chrome/browser/browser_hangs_experiment.cc » ('j') | chrome/browser/browser_hangs_experiment.cc » ('J')