third_party/WebKit/Source/modules/accessibility/AXLayoutObject.h - Issue 1905263002: Correctly finds line boundaries in objects with rich text on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/accessibility/AXLayoutObject.h

Issue 1905263002: Correctly finds line boundaries in objects with rich text on Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed standard text fields in unit test. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/accessibility/inline-text-box-next-on-line.html ('k') | ui/accessibility/ax_enums.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/accessibility/AXLayoutObject.h

diff --git a/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.h b/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.h

index 8a6a516b499c92a577fd1bf31542d4633ec2afbc..fe2cc96e7c865fa927412e989f7e154f8d228e82 100644

--- a/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.h

+++ b/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.h

@@ -189,7 +189,7 @@ protected:

// Text metrics. Most of these should be deprecated, needs major cleanup.

int index(const VisiblePosition&) const override;

VisiblePosition visiblePositionForIndex(int) const override;

- void lineBreaks(Vector<int>&) const override;

+ void lineBreaks(Vector<int>&) const final;

private:

AXObject* treeAncestorDisallowingChild() const;

« no previous file with comments | « third_party/WebKit/LayoutTests/accessibility/inline-text-box-next-on-line.html ('k') | ui/accessibility/ax_enums.idl » ('j') | no next file with comments »