Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 1905243003: [chrome.displaySource] Integrate audio encoders into media pipeline. (Closed)

Created:
4 years, 8 months ago by e_hakkinen
Modified:
4 years, 7 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[chrome.displaySource] Integrate audio encoders into media pipeline. This part of a Wi-Fi Display audo encoder patch series: * https://codereview.chromium.org/1899943005/ Add a base class for audio encoders. * https://codereview.chromium.org/1903823002/ Implement LPCM audio encoder. * https://codereview.chromium.org/1905243003/ <-- This CL Integrate audio encoders into media pipeline. BUG=242107 Committed: https://crrev.com/5e8d2f955b2f5d39f5ed1417361033cfb364969e Cr-Commit-Position: refs/heads/master@{#390617}

Patch Set 1 : #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -17 lines) Patch
M extensions/renderer/api/display_source/wifi_display/wifi_display_media_manager.h View 2 chunks +2 lines, -0 lines 0 comments Download
M extensions/renderer/api/display_source/wifi_display/wifi_display_media_manager.cc View 3 chunks +34 lines, -0 lines 0 comments Download
M extensions/renderer/api/display_source/wifi_display/wifi_display_media_pipeline.h View 1 3 chunks +8 lines, -0 lines 0 comments Download
M extensions/renderer/api/display_source/wifi_display/wifi_display_media_pipeline.cc View 1 2 7 chunks +48 lines, -17 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
e_hakkinen
PTAL.
4 years, 7 months ago (2016-04-28 05:57:06 UTC) #5
Mikhail
lgtm with a comment https://codereview.chromium.org/1905243003/diff/40001/extensions/renderer/api/display_source/wifi_display/wifi_display_media_pipeline.h File extensions/renderer/api/display_source/wifi_display/wifi_display_media_pipeline.h (right): https://codereview.chromium.org/1905243003/diff/40001/extensions/renderer/api/display_source/wifi_display/wifi_display_media_pipeline.h#newcode60 extensions/renderer/api/display_source/wifi_display/wifi_display_media_pipeline.h:60: content::MediaStreamAudioSink* audio_sink() { return audio_encoder_.get(); ...
4 years, 7 months ago (2016-04-28 12:28:19 UTC) #6
e_hakkinen
https://codereview.chromium.org/1905243003/diff/40001/extensions/renderer/api/display_source/wifi_display/wifi_display_media_pipeline.h File extensions/renderer/api/display_source/wifi_display/wifi_display_media_pipeline.h (right): https://codereview.chromium.org/1905243003/diff/40001/extensions/renderer/api/display_source/wifi_display/wifi_display_media_pipeline.h#newcode60 extensions/renderer/api/display_source/wifi_display/wifi_display_media_pipeline.h:60: content::MediaStreamAudioSink* audio_sink() { return audio_encoder_.get(); } On 2016/04/28 12:28:19, ...
4 years, 7 months ago (2016-04-28 12:50:57 UTC) #7
asargent_no_longer_on_chrome
Doesn't look like there's anything not covered by OWNERS who've already commented - let me ...
4 years, 7 months ago (2016-04-28 21:15:43 UTC) #8
e_hakkinen
On 2016/04/28 21:15:43, Antony Sargent wrote: > Doesn't look like there's anything not covered by ...
4 years, 7 months ago (2016-04-29 07:41:08 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1905243003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1905243003/80001
4 years, 7 months ago (2016-04-29 10:50:24 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:80001)
4 years, 7 months ago (2016-04-29 11:24:00 UTC) #14
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:24:59 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/5e8d2f955b2f5d39f5ed1417361033cfb364969e
Cr-Commit-Position: refs/heads/master@{#390617}

Powered by Google App Engine
This is Rietveld 408576698