Move Win x64 clobber bot and remove Win x64 GN bots.

Move Win x64 clobber bot and remove Win x64 GN bots.

This CL moves the Win x64 Clobber bot to the chromium waterfall
(from the FYI waterfall), and removes the x64 GN bots, now that
the main bots have been flipped to GN.

R=scottmg@chromium.org, wfh@chromium.org, brucedawson@chromium.org
BUG=605318
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300102

[Dirk Pranke, 2016-04-21 23:13:09]

Description was changed from

==========
Move Win x64 clobber bot and remove Win x64 GN bots.

This CL moves the Win x64 Clobber bot to the chromium waterfall
(from the FYI waterfall), and removes the x64 GN bots, now that
the main bots have been flipped to GN.

R=scottmg@chromium.org
BUG=605318
==========

to

==========
Move Win x64 clobber bot and remove Win x64 GN bots.

This CL moves the Win x64 Clobber bot to the chromium waterfall
(from the FYI waterfall), and removes the x64 GN bots, now that
the main bots have been flipped to GN.

R=scottmg@chromium.org, wfh@chromium.org, brucedawson@chromium.org
BUG=605318
==========

[Dirk Pranke, 2016-04-21 23:13:10]

dpranke@chromium.org changed reviewers:
+ brucedawson@chromium.org, wfh@chromium.org

[Dirk Pranke, 2016-04-21 23:13:21]

Please take a look?

[scottmg, 2016-04-21 23:18:17]

lgtm

[brucedawson, 2016-04-22 00:04:44]

lgtm, with one question about an indenting change.

https://codereview.chromium.org/1905213002/diff/20001/scripts/slave/recipes/c...
File scripts/slave/recipes/chromium_trybot.py (right):

https://codereview.chromium.org/1905213002/diff/20001/scripts/slave/recipes/c...
scripts/slave/recipes/chromium_trybot.py:288: api.test(test_name) +
This indent increase is harmless but seems anomalous. Accidental?

[Dirk Pranke, 2016-04-22 00:12:01]

https://codereview.chromium.org/1905213002/diff/20001/scripts/slave/recipes/c...
File scripts/slave/recipes/chromium_trybot.py (right):

https://codereview.chromium.org/1905213002/diff/20001/scripts/slave/recipes/c...
scripts/slave/recipes/chromium_trybot.py:288: api.test(test_name) +
On 2016/04/22 00:04:44, brucedawson wrote:
> This indent increase is harmless but seems anomalous. Accidental?

Yeah, I was debugging something and apparently didn't restore it properly. Will
fix.

[Dirk Pranke, 2016-04-22 00:13:59]

The CQ bit was checked by dpranke@chromium.org

[Dirk Pranke, 2016-04-22 00:14:00]

The patchset sent to the CQ was uploaded after l-g-t-m from
brucedawson@chromium.org, scottmg@chromium.org
Link to the patchset: https://codereview.chromium.org/1905213002/#ps40001
(title: "fix indent")

[commit-bot: I haz the power, 2016-04-22 00:14:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1905213002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1905213002/40001

[Dirk Pranke, 2016-04-22 00:14:42]

The CQ bit was unchecked by dpranke@chromium.org

[Dirk Pranke, 2016-04-22 00:50:21]

The CQ bit was checked by dpranke@chromium.org

[commit-bot: I haz the power, 2016-04-22 00:50:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1905213002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1905213002/40001

[commit-bot: I haz the power, 2016-04-22 00:54:29]

Description was changed from

==========
Move Win x64 clobber bot and remove Win x64 GN bots.

This CL moves the Win x64 Clobber bot to the chromium waterfall
(from the FYI waterfall), and removes the x64 GN bots, now that
the main bots have been flipped to GN.

R=scottmg@chromium.org, wfh@chromium.org, brucedawson@chromium.org
BUG=605318
==========

to

==========
Move Win x64 clobber bot and remove Win x64 GN bots.

This CL moves the Win x64 Clobber bot to the chromium waterfall
(from the FYI waterfall), and removes the x64 GN bots, now that
the main bots have been flipped to GN.

R=scottmg@chromium.org, wfh@chromium.org, brucedawson@chromium.org
BUG=605318

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300102
==========

[commit-bot: I haz the power, 2016-04-22 00:54:30]

Committed patchset #3 (id:40001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=300102

[kjellander_chromium, 2016-04-22 06:26:21]

kjellander@chromium.org changed reviewers:
+ kjellander@chromium.org

[kjellander_chromium, 2016-04-22 06:26:22]

Whoa, nice to see this happen but it caused a bit of extra work for me as Chrome
sheriff as none of the masters were restarted, since the Win x64 GN bots started
firing offline slave alerts (since the slaves no longer knew where to connect
to).

I restarted:
* chromium.win in https://chromereviews.googleplex.com/408377013/ 
* chromium in https://chromereviews.googleplex.com/412007013/ 

I haven't restarted tryserver.chromium.win since the trybots were optional -
I'll leave that to you.

You also mentioned moving GN bots from chromium.fyi in the description, but
that's the change that happened in https://codereview.chromium.org/700053006,
right?

lgtm, now that is :)

https://codereview.chromium.org/1905213002/diff/40001/masters/master.chromium...
File masters/master.chromium.win/slaves.cfg (left):

https://codereview.chromium.org/1905213002/diff/40001/masters/master.chromium...
masters/master.chromium.win/slaves.cfg:89: 'builder': 'Win x64 GN',
Removing these without restarting the master resulted in sheriff-o-matic alerts
about offline bots. I took care of it by restarting the master though.

https://codereview.chromium.org/1905213002/diff/40001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/chromium_tests/chromium_webrtc_fyi.py (right):

https://codereview.chromium.org/1905213002/diff/40001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromium_tests/chromium_webrtc_fyi.py:24: def
AddGNBuilder(spec, name, dest_name=None):
Thanks updating my bots :)

[Dirk Pranke, 2016-04-22 17:41:03]

On 2016/04/22 06:26:22, kjellander (chromium) wrote:
> Whoa, nice to see this happen but it caused a bit of extra work for me as
Chrome
> sheriff as none of the masters were restarted, since the Win x64 GN bots
started
> firing offline slave alerts (since the slaves no longer knew where to connect
> to).
> 
> I restarted:
> * chromium.win in https://chromereviews.googleplex.com/408377013/ 
> * chromium in https://chromereviews.googleplex.com/412007013/ 

Urk, sorry, I forgot about the offline slave alerts, I was planning to restart
everything this morning. Sorry!

> I haven't restarted tryserver.chromium.win since the trybots were optional -
> I'll leave that to you.

Yup, thanks!

> You also mentioned moving GN bots from chromium.fyi in the description, but
> that's the change that happened in https://codereview.chromium.org/700053006,
> right?

I took the x64 bot off of FYI in that CL, and added it to chromium in this CL.