Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(885)

Unified Diff: tools/rebaseline.py

Issue 19052007: rebaseline.py: skip any platforms we don't have actual results for, with warning message (Closed) Base URL: http://skia.googlecode.com/svn/trunk/
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/rebaseline.py
===================================================================
--- tools/rebaseline.py (revision 10016)
+++ tools/rebaseline.py (working copy)
@@ -62,8 +62,6 @@
'Test-Android-Nexus7-Tegra3-Arm7-Release',
'base-android-nexus-s':
'Test-Android-NexusS-SGX540-Arm7-Release',
- 'base-android-xoom':
- 'Test-Android-Xoom-Tegra2-Arm7-Release',
borenet 2013/07/11 18:11:34 I'm pretty sure we still want this. The GMs just
epoger 2013/07/11 18:16:17 The problem is, because we have NO actual results
borenet 2013/07/11 18:20:08 Do we really want it to fail? My preference would
'base-android-nexus-10':
'Test-Android-Nexus10-MaliT604-Arm7-Release',
'base-android-nexus-4':
@@ -108,7 +106,10 @@
# a path on local storage.
def _GetFileContents(self, filepath):
if filepath.startswith('http:') or filepath.startswith('https:'):
- return urllib2.urlopen(filepath).read()
+ try:
+ return urllib2.urlopen(filepath).read()
+ except urllib2.HTTPError as e:
+ raise Exception('unable to read URL %s: %s' % (filepath, e))
epoger 2013/07/11 18:08:30 while I was at it, improved error reporting so the
else:
return open(filepath, 'r').read()
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698