Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(565)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1905173002: Add a debugging tool for inspecting the contents of a summary file. (Closed)

Created:
4 years, 8 months ago by Paul Berry
Modified:
4 years, 8 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add a debugging tool for inspecting the contents of a summary file. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/d8e8cbe3c868ec2f3aa1104f1dcc7628abc27e03

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+449 lines, -0 lines) Patch
A pkg/analyzer/lib/src/summary/inspect.dart View 1 chunk +428 lines, -0 lines 4 comments Download
A pkg/analyzer/tool/summary/inspect.dart View 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Paul Berry
4 years, 8 months ago (2016-04-21 21:53:28 UTC) #2
scheglov
LGTM https://codereview.chromium.org/1905173002/diff/1/pkg/analyzer/lib/src/summary/inspect.dart File pkg/analyzer/lib/src/summary/inspect.dart (right): https://codereview.chromium.org/1905173002/diff/1/pkg/analyzer/lib/src/summary/inspect.dart#newcode63 pkg/analyzer/lib/src/summary/inspect.dart:63: * of entities (represented by [parts]) contined between ...
4 years, 8 months ago (2016-04-21 22:11:42 UTC) #3
Paul Berry
https://codereview.chromium.org/1905173002/diff/1/pkg/analyzer/lib/src/summary/inspect.dart File pkg/analyzer/lib/src/summary/inspect.dart (right): https://codereview.chromium.org/1905173002/diff/1/pkg/analyzer/lib/src/summary/inspect.dart#newcode63 pkg/analyzer/lib/src/summary/inspect.dart:63: * of entities (represented by [parts]) contined between [opener] ...
4 years, 8 months ago (2016-04-21 22:31:09 UTC) #4
Paul Berry
4 years, 8 months ago (2016-04-21 22:31:48 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
d8e8cbe3c868ec2f3aa1104f1dcc7628abc27e03 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698