Fix CSSParserToken::operator== for NumberTokens

Fix CSSParserToken::operator== for NumberTokens

This patch fixes equality for CSSParserToken to not compare the
dimension values when comparing NumberTokens. These are only valid
for DimensionTokens. We also now compare whether tokens were specified
with a sign (+/-/nothing) for dimensions and percentages.

Since the operator== function is fairly large, it is also moved from
the header file to the .cpp file.

BUG=590801
Committed: https://crrev.com/b59bf7c191bc204ceb046c2743246ff45a8798f6
Cr-Commit-Position: refs/heads/master@{#390593}

[Timothy Loh, 2016-04-22 06:02:42]

timloh@chromium.org changed reviewers:
+ alancutter@chromium.org

[Timothy Loh, 2016-04-22 06:02:42]

I checked on MSAN and this fixes the linked bug.

[alancutter (OOO until 2018), 2016-04-29 03:01:56]

lgtm

[Timothy Loh, 2016-04-29 03:52:48]

The CQ bit was checked by timloh@chromium.org

[commit-bot: I haz the power, 2016-04-29 03:53:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1905163003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1905163003/20001

[commit-bot: I haz the power, 2016-04-29 05:02:28]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-30 17:24:21]

Patchset 2 (id:??) landed as
https://crrev.com/b59bf7c191bc204ceb046c2743246ff45a8798f6
Cr-Commit-Position: refs/heads/master@{#390593}

[commit-bot: I haz the power, 2016-04-30 17:59:35]

Description was changed from

==========
Fix CSSParserToken::operator== for NumberTokens

This patch fixes equality for CSSParserToken to not compare the
dimension values when comparing NumberTokens. These are only valid
for DimensionTokens. We also now compare whether tokens were specified
with a sign (+/-/nothing) for dimensions and percentages.

Since the operator== function is fairly large, it is also moved from
the header file to the .cpp file.

BUG=590801
==========

to

==========
Fix CSSParserToken::operator== for NumberTokens

This patch fixes equality for CSSParserToken to not compare the
dimension values when comparing NumberTokens. These are only valid
for DimensionTokens. We also now compare whether tokens were specified
with a sign (+/-/nothing) for dimensions and percentages.

Since the operator== function is fairly large, it is also moved from
the header file to the .cpp file.

BUG=590801

Committed: https://crrev.com/b59bf7c191bc204ceb046c2743246ff45a8798f6
Cr-Commit-Position: refs/heads/master@{#390593}
==========