Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.mm

Issue 1905163002: [Mac][Material Design] Rework how location bar shadow is drawn. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.mm
diff --git a/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.mm b/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.mm
index ca33657b14d0dff8605484b03c4dbdfc727d9b95..b75fcf4bc1216b7c801c41cef3b125a82e507aec 100644
--- a/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.mm
+++ b/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.mm
@@ -314,10 +314,6 @@ size_t CalculatePositionsInFrame(
// Compute the border's bezier path.
NSRect pathRect = NSInsetRect(frame, insetSize, insetSize);
- // In dark mode, make room for a shadow beneath the bottom edge.
- if (inDarkMode && isModeMaterial) {
- pathRect.size.height -= singlePixelLineWidth_;
- }
NSBezierPath* path =
[NSBezierPath bezierPathWithRoundedRect:pathRect
xRadius:kCornerRadius
@@ -366,7 +362,7 @@ size_t CalculatePositionsInFrame(
}
// Draw a highlight beneath the top edge, and a shadow beneath the bottom
- // edge.
+ // edge when on a Retina screen.
{
gfx::ScopedNSGraphicsContextSaveGState saveState;
[NSBezierPath setDefaultLineWidth:singlePixelLineWidth_];
@@ -380,10 +376,12 @@ size_t CalculatePositionsInFrame(
[NSBezierPath strokeLineFromPoint:origin
toPoint:destination];
- origin.y = destination.y = NSMaxY(pathRect) + singlePixelLineWidth_;
- [[NSColor colorWithCalibratedWhite:69 / 255. alpha:1] set];
- [NSBezierPath strokeLineFromPoint:origin
- toPoint:destination];
+ if (singlePixelLineWidth_ < 1) {
+ origin.y = destination.y = NSMaxY(pathRect) + singlePixelLineWidth_;
+ [[AutocompleteTextField shadowColor] set];
+ [NSBezierPath strokeLineFromPoint:origin
+ toPoint:destination];
+ }
}
}
} else {

Powered by Google App Engine
This is Rietveld 408576698