Autofill: Check for common angular js prefix when filling exp month.

Autofill: Check for common angular js prefix when filling exp month.

BUG=602987
TEST=AutofillFieldTest

Committed: https://crrev.com/d9f8818992a4f18090aeca2cfff70dfc9504571b
Cr-Commit-Position: refs/heads/master@{#389121}

[Mathieu, 2016-04-21 19:57:55]

mathp@chromium.org changed reviewers:
+ jdonnelly@chromium.org

[Mathieu, 2016-04-21 19:57:55]

Hi Justin, can you have a look? Thanks

[Justin Donnelly, 2016-04-21 20:11:11]

lgtm with minor suggestion

https://codereview.chromium.org/1905143002/diff/1/components/autofill/core/br...
File components/autofill/core/browser/autofill_field.cc (right):

https://codereview.chromium.org/1905143002/diff/1/components/autofill/core/br...
components/autofill/core/browser/autofill_field.cc:207:
base::ReplaceSubstringsAfterOffset(&trimmed_values[i], 0, kNumberPrefix,
ReplaceFirstSubstringAfterOffset?

[Mathieu, 2016-04-22 02:30:37]

Thanks, submitting

https://codereview.chromium.org/1905143002/diff/1/components/autofill/core/br...
File components/autofill/core/browser/autofill_field.cc (right):

https://codereview.chromium.org/1905143002/diff/1/components/autofill/core/br...
components/autofill/core/browser/autofill_field.cc:207:
base::ReplaceSubstringsAfterOffset(&trimmed_values[i], 0, kNumberPrefix,
On 2016/04/21 20:11:10, Justin Donnelly wrote:
> ReplaceFirstSubstringAfterOffset?

Oops, thanks!

[Mathieu, 2016-04-22 02:30:40]

The CQ bit was checked by mathp@chromium.org

[Mathieu, 2016-04-22 02:30:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
jdonnelly@chromium.org
Link to the patchset: https://codereview.chromium.org/1905143002/#ps20001
(title: "ReplaceFirstSubstringAfterOffset")

[commit-bot: I haz the power, 2016-04-22 02:30:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1905143002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1905143002/20001

[commit-bot: I haz the power, 2016-04-22 02:45:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-22 02:45:04]

Try jobs failed on following builders:
  ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)

[Mathieu, 2016-04-22 13:28:17]

The CQ bit was checked by mathp@chromium.org

[commit-bot: I haz the power, 2016-04-22 13:28:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1905143002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1905143002/20001

[commit-bot: I haz the power, 2016-04-22 13:41:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-22 13:41:23]

Try jobs failed on following builders:
  ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)

[Mathieu, 2016-04-22 14:31:53]

The CQ bit was checked by mathp@chromium.org

[Mathieu, 2016-04-22 14:31:54]

The patchset sent to the CQ was uploaded after l-g-t-m from
jdonnelly@chromium.org
Link to the patchset: https://codereview.chromium.org/1905143002/#ps40001
(title: "fix code")

[commit-bot: I haz the power, 2016-04-22 14:32:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1905143002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1905143002/40001

[commit-bot: I haz the power, 2016-04-22 15:50:55]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-22 19:47:59]

Description was changed from

==========
Autofill: Check for common angular js prefix when filling exp month.

BUG=602987
TEST=AutofillFieldTest
==========

to

==========
Autofill: Check for common angular js prefix when filling exp month.

BUG=602987
TEST=AutofillFieldTest

Committed: https://crrev.com/d9f8818992a4f18090aeca2cfff70dfc9504571b
Cr-Commit-Position: refs/heads/master@{#389121}
==========

[commit-bot: I haz the power, 2016-04-22 19:48:00]

Patchset 3 (id:??) landed as
https://crrev.com/d9f8818992a4f18090aeca2cfff70dfc9504571b
Cr-Commit-Position: refs/heads/master@{#389121}