Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1189)

Side by Side Diff: components/version_ui/resources/about_version.js

Issue 1905113002: Add ARC version to help and version pages (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nits Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * Callback from the backend with the list of variations to display. 6 * Callback from the backend with the list of variations to display.
7 * This call will build the variations section of the version page, or hide that 7 * This call will build the variations section of the version page, or hide that
8 * section if there are none to display. 8 * section if there are none to display.
9 * @param {!Array<string>} variationsList The list of variations. 9 * @param {!Array<string>} variationsList The list of variations.
10 */ 10 */
(...skipping 22 matching lines...) Expand all
33 } 33 }
34 34
35 /** 35 /**
36 * Callback from the backend with the OS version to display. 36 * Callback from the backend with the OS version to display.
37 * @param {string} osVersion The OS version to display. 37 * @param {string} osVersion The OS version to display.
38 */ 38 */
39 function returnOsVersion(osVersion) { 39 function returnOsVersion(osVersion) {
40 $('os_version').textContent = osVersion; 40 $('os_version').textContent = osVersion;
41 } 41 }
42 42
43
44 /**
45 * Callback from the backend with the ARC version to display.
46 * @param {string} arcVersion The ARC version to display.
47 */
48 function returnARCVersion(arcVersion) {
49 $('arc_version').textContent = arcVersion;
50 $('arc_holder').hidden = !arcVersion;
51 }
52
43 /* All the work we do onload. */ 53 /* All the work we do onload. */
44 function onLoadWork() { 54 function onLoadWork() {
45 chrome.send('requestVersionInfo'); 55 chrome.send('requestVersionInfo');
56 $('arc_holder').hidden = true;
46 } 57 }
47 58
48 document.addEventListener('DOMContentLoaded', onLoadWork); 59 document.addEventListener('DOMContentLoaded', onLoadWork);
OLDNEW
« no previous file with comments | « components/version_ui/resources/about_version.html ('k') | components/version_ui/version_ui_constants.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698