Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(553)

Issue 1905103002: 🐮 Add dummy junit targets so that GYP & GN have the same targets (Closed)

Created:
4 years, 8 months ago by agrieve
Modified:
4 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add dummy junit targets so that GYP & GN have the same targets The bot recipes need to work with both GYP & GN. BUG=605674 Committed: https://crrev.com/fc13c2614d73b713cd3610fbccb504d7e8538cba Cr-Commit-Position: refs/heads/master@{#389174}

Patch Set 1 #

Patch Set 2 : forgot to add java file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -2 lines) Patch
M components/BUILD.gn View 1 chunk +6 lines, -0 lines 0 comments Download
M components/invalidation.gypi View 1 chunk +15 lines, -0 lines 0 comments Download
M components/policy.gypi View 1 chunk +15 lines, -0 lines 0 comments Download
M components/web_restrictions.gypi View 1 chunk +16 lines, -2 lines 0 comments Download
A testing/android/junit/DummyTest.java View 1 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
agrieve
4 years, 8 months ago (2016-04-21 19:03:20 UTC) #2
agrieve
dpranke for testing/
4 years, 8 months ago (2016-04-21 19:05:04 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1905103002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1905103002/20001
4 years, 8 months ago (2016-04-21 19:05:43 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-21 20:27:41 UTC) #9
agrieve
dpranke@chromium.org: Please review changes in testing/
4 years, 8 months ago (2016-04-22 13:51:13 UTC) #11
jochen (gone - plz use gerrit)
lgtm
4 years, 8 months ago (2016-04-22 15:28:40 UTC) #12
Dirk Pranke
rs- lgtm.
4 years, 8 months ago (2016-04-22 18:19:11 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1905103002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1905103002/20001
4 years, 8 months ago (2016-04-22 18:22:22 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-22 18:29:43 UTC) #16
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:50:07 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fc13c2614d73b713cd3610fbccb504d7e8538cba
Cr-Commit-Position: refs/heads/master@{#389174}

Powered by Google App Engine
This is Rietveld 408576698