Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1905063002: Guard against FramebufferStatus checks in GrGLRenderTarget (Closed)

Created:
4 years, 8 months ago by robertphillips
Modified:
4 years, 8 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Fix comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -6 lines) Patch
M src/gpu/gl/GrGLRenderTarget.cpp View 1 2 chunks +14 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
robertphillips
4 years, 8 months ago (2016-04-21 17:39:08 UTC) #4
bsalomon
lgtm
4 years, 8 months ago (2016-04-21 18:05:27 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1905063002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1905063002/20001
4 years, 8 months ago (2016-04-21 18:13:48 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-21 18:26:19 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1905063002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1905063002/20001
4 years, 8 months ago (2016-04-21 18:26:48 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-21 18:27:46 UTC) #13
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/fa7ff470a83183ba0d22a8b83a022e2e3122e851

Powered by Google App Engine
This is Rietveld 408576698