content/browser/loader/navigation_url_loader_unittest.cc - Issue 1905033002: PlzNavigate: Move navigation-level mixed content checks to the browser.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/loader/navigation_url_loader_unittest.cc

Issue 1905033002: PlzNavigate: Move navigation-level mixed content checks to the browser. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@console-security-message

Patch Set: Addressed all jam@ latest comments. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/frame_host/mixed_content_navigation_throttle.h ('K') | « content/browser/loader/navigation_resource_throttle.cc ('k') | content/browser/loader/resource_dispatcher_host_impl.h » ('j') | content/common/DEPS » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/loader/navigation_url_loader_unittest.cc

diff --git a/content/browser/loader/navigation_url_loader_unittest.cc b/content/browser/loader/navigation_url_loader_unittest.cc

index 2b60f6501cf7d2c0c43432dc0528b4a7ed42fad4..29fed3e4ac6e249a52c083965c4264f16e4d1039 100644

--- a/content/browser/loader/navigation_url_loader_unittest.cc

+++ b/content/browser/loader/navigation_url_loader_unittest.cc

@@ -106,9 +106,10 @@ class NavigationURLLoaderTest : public testing::Test {

std::unique_ptr<NavigationURLLoader> MakeTestLoader(

const GURL& url,

NavigationURLLoaderDelegate* delegate) {

- BeginNavigationParams begin_params(std::string(), net::LOAD_NORMAL, false,

- false, REQUEST_CONTEXT_TYPE_LOCATION,

- url::Origin(url));

+ BeginNavigationParams begin_params(

+ std::string(), net::LOAD_NORMAL, false, false,

+ REQUEST_CONTEXT_TYPE_LOCATION,

+ blink::WebMixedContentContextType::Blockable, url::Origin(url));

CommonNavigationParams common_params;

common_params.url = url;

std::unique_ptr<NavigationRequestInfo> request_info(