content/test/test_render_frame_host.cc - Issue 1905033002: PlzNavigate: Move navigation-level mixed content checks to the browser.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/test/test_render_frame_host.cc

Issue 1905033002: PlzNavigate: Move navigation-level mixed content checks to the browser. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@console-security-message

Patch Set: MixedContent::ContextType comes from the renderer; lessen Blink public code; fixed build. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/frame_host/mixed_content_navigation_throttle.cc ('K') | « content/test/BUILD.gn ('k') | net/url_request/url_request.h » ('j') | third_party/WebKit/public/platform/WebMixedContent.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/test/test_render_frame_host.cc

diff --git a/content/test/test_render_frame_host.cc b/content/test/test_render_frame_host.cc

index 02b50aed4633e8dc90409717703545e2be345a84..a84f1c420e5147fcfcb3b3a428d0134e940ac2b6 100644

--- a/content/test/test_render_frame_host.cc

+++ b/content/test/test_render_frame_host.cc

@@ -24,6 +24,7 @@

#include "content/test/test_render_view_host.h"

#include "mojo/public/cpp/bindings/interface_request.h"

#include "net/base/load_flags.h"

+#include "third_party/WebKit/public/platform/WebMixedContent.h"

#include "third_party/WebKit/public/platform/WebPageVisibilityState.h"

#include "third_party/WebKit/public/platform/modules/bluetooth/web_bluetooth.mojom.h"

#include "third_party/WebKit/public/web/WebSandboxFlags.h"

@@ -412,7 +413,8 @@ void TestRenderFrameHost::SendRendererInitiatedNavigationRequest(

// TODO(mkwst): The initiator origin here is incorrect.

BeginNavigationParams begin_params(

std::string(), net::LOAD_NORMAL, has_user_gesture, false,

- REQUEST_CONTEXT_TYPE_HYPERLINK, url::Origin());

+ REQUEST_CONTEXT_TYPE_HYPERLINK,

+ blink::WebMixedContent::ContextType::Blockable, url::Origin());

CommonNavigationParams common_params;

common_params.url = url;

common_params.referrer = Referrer(GURL(), blink::WebReferrerPolicyDefault);