Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Unified Diff: third_party/WebKit/Source/core/loader/MixedContentChecker.h

Issue 1905033002: PlzNavigate: Move navigation-level mixed content checks to the browser. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@console-security-message
Patch Set: Minor changes from nasko@'s comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/loader/MixedContentChecker.h
diff --git a/third_party/WebKit/Source/core/loader/MixedContentChecker.h b/third_party/WebKit/Source/core/loader/MixedContentChecker.h
index 33e8a1a82f912cf420a7de0e7aa3d51d85ed4f20..7aca72fdab9c65c8ae594b98cac4629d95808d8d 100644
--- a/third_party/WebKit/Source/core/loader/MixedContentChecker.h
+++ b/third_party/WebKit/Source/core/loader/MixedContentChecker.h
@@ -47,6 +47,14 @@ class KURL;
class ResourceResponse;
class SecurityOrigin;
+// Checks resource loads for mixed content. If PlzNavigate is enabled then this
+// class only checks for sub-resource loads while frame-level loads are
+// delegated to the browser where they are checked by
+// MixedContentNavigationThrottle. Changes to this class might need to be
+// reflected on its browser counterpart.
+//
+// Current mixed content W3C draft that drives this implementation:
+// https://w3c.github.io/webappsec-mixed-content/
class CORE_EXPORT MixedContentChecker final {
WTF_MAKE_NONCOPYABLE(MixedContentChecker);
DISALLOW_NEW();
@@ -94,6 +102,14 @@ class CORE_EXPORT MixedContentChecker final {
WebURLRequest::FrameType,
WebURLRequest::RequestContext);
+ // Receive information about mixed content found externally.
+ static void mixedContentFound(LocalFrame*,
+ const KURL& mainResourceUrl,
+ const KURL& mixedContentUrl,
+ WebURLRequest::RequestContext,
+ bool wasAllowed,
+ bool hadRedirect);
+
private:
FRIEND_TEST_ALL_PREFIXES(MixedContentCheckerTest, HandleCertificateError);

Powered by Google App Engine
This is Rietveld 408576698