Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(705)

Unified Diff: content/renderer/render_frame_impl.cc

Issue 1905033002: PlzNavigate: Move navigation-level mixed content checks to the browser. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@console-security-message
Patch Set: Address jam@ comments; many minor code and comment updates. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index 329180424a12fd9209732cb7ed25fb5c066d8549..0d28358caa313dcc51c87fdf45d3f2f424e0758a 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -1578,6 +1578,10 @@ bool RenderFrameImpl::OnMessageReceived(const IPC::Message& msg) {
OnSetHasReceivedUserGesture)
IPC_MESSAGE_HANDLER(FrameMsg_RunFileChooserResponse, OnFileChooserResponse)
IPC_MESSAGE_HANDLER(FrameMsg_ClearFocusedElement, OnClearFocusedElement)
+ IPC_MESSAGE_HANDLER(FrameMsg_BlinkFeatureUsageReport,
+ OnBlinkFeatureUsageReport)
+ IPC_MESSAGE_HANDLER(FrameMsg_MixedContentFound,
+ OnMixedContentFoundByTheBrowser)
nasko 2017/01/12 18:32:38 Also on the naming, we usually just prefix the IPC
carlosk 2017/01/21 02:54:59 Acknowledged.
#if defined(OS_ANDROID)
IPC_MESSAGE_HANDLER(FrameMsg_ActivateNearestFindResult,
OnActivateNearestFindResult)
@@ -5658,6 +5662,23 @@ void RenderFrameImpl::OnClearFocusedElement() {
webview->clearFocusedElement();
}
+void RenderFrameImpl::OnBlinkFeatureUsageReport(const std::set<int>& features) {
+ frame_->blinkFeatureUsageReport(features);
+}
+
+void RenderFrameImpl::OnMixedContentFoundByTheBrowser(
+ const GURL& main_resource_url,
+ const GURL& mixed_content_url,
+ RequestContextType request_context_type,
+ bool was_allowed,
+ bool had_redirect) {
+ auto request_context =
+ static_cast<blink::WebURLRequest::RequestContext>(request_context_type);
+ frame_->mixedContentFoundByTheBrowser(main_resource_url, mixed_content_url,
+ request_context, was_allowed,
+ had_redirect);
+}
+
#if defined(OS_ANDROID)
void RenderFrameImpl::OnActivateNearestFindResult(int request_id,
float x,

Powered by Google App Engine
This is Rietveld 408576698